sugar/linux
1
0
Fork 0
Code Activity

fbcon: uninline four foo_update_attr() functions

Browse Source 
This patch uninlines four similar functions, foo_update_attr(), in four
fbcon-related files.

These functions contain loops, two of theam have _nested_ loops, and they
have more than one callsite each.  I think they should not be inlined.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Denys Vlasenko
2010-08-10 18:02:29 -07:00
committed by Linus Torvalds
parent da909ce4c0
commit 26c5be3c75
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/video/console/bitblit.c
View File

@@ -22,7 +22,7 @@
/* /*
* Accelerated handlers. * Accelerated handlers.
*/ */
static inline void update_attr(u8 *dst, u8 *src, int attribute, static void update_attr(u8 *dst, u8 *src, int attribute,
struct vc_data *vc) struct vc_data *vc)
{ {
int i, offset = (vc->vc_font.height < 10) ? 1 : 2; int i, offset = (vc->vc_font.height < 10) ? 1 : 2;

2
drivers/video/console/fbcon_ccw.c
View File

@@ -22,7 +22,7 @@
* Rotation 270 degrees * Rotation 270 degrees
*/ */
static inline void ccw_update_attr(u8 *dst, u8 *src, int attribute, static void ccw_update_attr(u8 *dst, u8 *src, int attribute,
struct vc_data *vc) struct vc_data *vc)
{ {
int i, j, offset = (vc->vc_font.height < 10) ? 1 : 2; int i, j, offset = (vc->vc_font.height < 10) ? 1 : 2;

2
drivers/video/console/fbcon_cw.c
View File

@@ -22,7 +22,7 @@
* Rotation 90 degrees * Rotation 90 degrees
*/ */
static inline void cw_update_attr(u8 *dst, u8 *src, int attribute, static void cw_update_attr(u8 *dst, u8 *src, int attribute,
struct vc_data *vc) struct vc_data *vc)
{ {
int i, j, offset = (vc->vc_font.height < 10) ? 1 : 2; int i, j, offset = (vc->vc_font.height < 10) ? 1 : 2;

2
drivers/video/console/fbcon_ud.c
View File

@@ -22,7 +22,7 @@
* Rotation 180 degrees * Rotation 180 degrees
*/ */
static inline void ud_update_attr(u8 *dst, u8 *src, int attribute, static void ud_update_attr(u8 *dst, u8 *src, int attribute,
struct vc_data *vc) struct vc_data *vc)
{ {
int i, offset = (vc->vc_font.height < 10) ? 1 : 2; int i, offset = (vc->vc_font.height < 10) ? 1 : 2;