sugar/linux
1
0
Fork 0
Code Activity

cifs: Use GFP_ATOMIC when a lock is held in cifs_mount()

Browse Source 
A spin lock is held before kstrndup, it may sleep with holding
the spinlock, so we should use GFP_ATOMIC instead.

Fixes: e58c31d5e387 ("cifs: Add support for failover in cifs_reconnect()")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Paulo Alcantara <palcantara@suse.de>
This commit is contained in:
YueHaibing
2018-12-18 01:34:39 +00:00
committed by Steve French
parent 93d5cb517d
commit 2f0a617448
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
fs/cifs/connect.c
View File

@@ -4585,7 +4585,8 @@ int cifs_mount(struct cifs_sb_info *cifs_sb, struct smb_vol *vol)
tcon->remap = cifs_remap(cifs_sb);
}
cifs_sb->origin_fullpath = kstrndup(tcon->dfs_path,
strlen(tcon->dfs_path), GFP_KERNEL);
strlen(tcon->dfs_path),
GFP_ATOMIC);
if (!cifs_sb->origin_fullpath) {
spin_unlock(&cifs_tcp_ses_lock);
rc = -ENOMEM;