sugar/linux
1
0
Fork 0
Code Activity

[media] exynos4-is: constify v4l2_subdev_* structures

Browse Source 
v4l2_subdev_{core/pad/video}_ops structures are stored in the
fields of the v4l2_subdev_ops structure which are of type const.
Also, v4l2_subdev_ops structure is passed to a function
having its argument of type const. As these structures are never
modified, so declare them as const.
Done using Coccinelle:(one of the scripts used)

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct v4l2_subdev_ops i@p = {...};

@ok1@
identifier r1.i;
position p;
expression e1;
@@
v4l2_subdev_init(e1,&i@p)

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct v4l2_subdev_ops i;

File size before:
   text	   data	    bss	    dec	    hex	filename
  16830	   1064	      0	  17894	   45e6 platform/exynos4-is/fimc-capture.o
   7787	    704	     20	   8511	   213f platform/exynos4-is/mipi-csis.o

File size after:
   text	   data	    bss	    dec	    hex	filename
  17022	    880	      0	  17902	   45ee platform/exynos4-is/fimc-capture.o
   8299	    192	     20	   8511	   213f platform/exynos4-is/mipi-csis.o

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Bhumika Goyal
2016-12-12 16:03:57 -02:00
committed by Mauro Carvalho Chehab
parent 4742575cde
commit a2fafda66d
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/platform/exynos4-is/fimc-capture.c
View File

@@ -1695,7 +1695,7 @@ static int fimc_subdev_set_selection(struct v4l2_subdev *sd,
return 0; return 0;
} }
static struct v4l2_subdev_pad_ops fimc_subdev_pad_ops = { static const struct v4l2_subdev_pad_ops fimc_subdev_pad_ops = {
.enum_mbus_code = fimc_subdev_enum_mbus_code, .enum_mbus_code = fimc_subdev_enum_mbus_code,
.get_selection = fimc_subdev_get_selection, .get_selection = fimc_subdev_get_selection,
.set_selection = fimc_subdev_set_selection, .set_selection = fimc_subdev_set_selection,
@@ -1703,7 +1703,7 @@ static struct v4l2_subdev_pad_ops fimc_subdev_pad_ops = {
.set_fmt = fimc_subdev_set_fmt, .set_fmt = fimc_subdev_set_fmt,
}; };
static struct v4l2_subdev_ops fimc_subdev_ops = { static const struct v4l2_subdev_ops fimc_subdev_ops = {
.pad = &fimc_subdev_pad_ops, .pad = &fimc_subdev_pad_ops,
}; };

8
drivers/media/platform/exynos4-is/mipi-csis.c
View File

@@ -649,23 +649,23 @@ static int s5pcsis_log_status(struct v4l2_subdev *sd)
return 0; return 0;
} }
static struct v4l2_subdev_core_ops s5pcsis_core_ops = { static const struct v4l2_subdev_core_ops s5pcsis_core_ops = {
.s_power = s5pcsis_s_power, .s_power = s5pcsis_s_power,
.log_status = s5pcsis_log_status, .log_status = s5pcsis_log_status,
}; };
static struct v4l2_subdev_pad_ops s5pcsis_pad_ops = { static const struct v4l2_subdev_pad_ops s5pcsis_pad_ops = {
.enum_mbus_code = s5pcsis_enum_mbus_code, .enum_mbus_code = s5pcsis_enum_mbus_code,
.get_fmt = s5pcsis_get_fmt, .get_fmt = s5pcsis_get_fmt,
.set_fmt = s5pcsis_set_fmt, .set_fmt = s5pcsis_set_fmt,
}; };
static struct v4l2_subdev_video_ops s5pcsis_video_ops = { static const struct v4l2_subdev_video_ops s5pcsis_video_ops = {
.s_rx_buffer = s5pcsis_s_rx_buffer, .s_rx_buffer = s5pcsis_s_rx_buffer,
.s_stream = s5pcsis_s_stream, .s_stream = s5pcsis_s_stream,
}; };
static struct v4l2_subdev_ops s5pcsis_subdev_ops = { static const struct v4l2_subdev_ops s5pcsis_subdev_ops = {
.core = &s5pcsis_core_ops, .core = &s5pcsis_core_ops,
.pad = &s5pcsis_pad_ops, .pad = &s5pcsis_pad_ops,
.video = &s5pcsis_video_ops, .video = &s5pcsis_video_ops,