ata: Convert dev_printk(KERN_<LEVEL> to dev_<level>(
Saves a bit of text as the call takes fewer args. Coalesce a few formats. Convert a few bare printks to pr_cont. $ size drivers/ata/built-in.o* text data bss dec hex filename 558429 73893 117864 750186 b726a drivers/ata/built-in.o.allyesconfig.new 559574 73893 117888 751355 b76fb drivers/ata/built-in.o.allyesconfig.old 149567 14689 4220 168476 2921c drivers/ata/built-in.o.defconfig.new 149851 14689 4220 168760 29338 drivers/ata/built-in.o.defconfig.old Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
This commit is contained in:
@@ -470,7 +470,7 @@ static int atp867x_ata_pci_sff_init_host(struct ata_host *host)
|
||||
}
|
||||
|
||||
if (!mask) {
|
||||
dev_printk(KERN_ERR, gdev, "no available native port\n");
|
||||
dev_err(gdev, "no available native port\n");
|
||||
return -ENODEV;
|
||||
}
|
||||
|
||||
@@ -500,7 +500,7 @@ static int atp867x_init_one(struct pci_dev *pdev,
|
||||
int rc;
|
||||
|
||||
if (!printed_version++)
|
||||
dev_printk(KERN_INFO, &pdev->dev, "version " DRV_VERSION "\n");
|
||||
dev_info(&pdev->dev, "version " DRV_VERSION "\n");
|
||||
|
||||
rc = pcim_enable_device(pdev);
|
||||
if (rc)
|
||||
@@ -511,15 +511,14 @@ static int atp867x_init_one(struct pci_dev *pdev,
|
||||
|
||||
host = ata_host_alloc_pinfo(&pdev->dev, ppi, ATP867X_NUM_PORTS);
|
||||
if (!host) {
|
||||
dev_printk(KERN_ERR, &pdev->dev,
|
||||
"failed to allocate ATA host\n");
|
||||
dev_err(&pdev->dev, "failed to allocate ATA host\n");
|
||||
rc = -ENOMEM;
|
||||
goto err_out;
|
||||
}
|
||||
|
||||
rc = atp867x_ata_pci_sff_init_host(host);
|
||||
if (rc) {
|
||||
dev_printk(KERN_ERR, &pdev->dev, "failed to init host\n");
|
||||
dev_err(&pdev->dev, "failed to init host\n");
|
||||
goto err_out;
|
||||
}
|
||||
|
||||
@@ -528,7 +527,7 @@ static int atp867x_init_one(struct pci_dev *pdev,
|
||||
rc = ata_host_activate(host, pdev->irq, ata_bmdma_interrupt,
|
||||
IRQF_SHARED, &atp867x_sht);
|
||||
if (rc)
|
||||
dev_printk(KERN_ERR, &pdev->dev, "failed to activate host\n");
|
||||
dev_err(&pdev->dev, "failed to activate host\n");
|
||||
|
||||
err_out:
|
||||
return rc;
|
||||
|
||||
Reference in New Issue
Block a user