Bart Van Assche
08965c2eba
Revert "sd: remove __data_len hack for WRITE SAME"
This patch reverts commit f80de881d8 and avoids that sending a
WRITE SAME command to the iSCSI initiator triggers the following:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000014
TARGET_CORE[iSCSI]: Expected Transfer Length: 260096 does not match SCSI CDB Length: 512 for SAM Opcode: 0x41
IP: iscsi_tcp_segment_done+0x20b/0x310 [libiscsi_tcp]
Oops: 0000 [#1] SMP
Modules linked in: target_core_user uio target_core_iblock target_core_file iscsi_target_mod target_core_mod netconsole configfs crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel aes_x86_64 crypto_simd cryptd glue_helper virtio_console virtio_rng virtio_balloon serio_raw i2c_piix4 acpi_cpufreq button iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi ext4 jbd2 mbcache virtio_blk virtio_net psmouse floppy drm_kms_helper syscopyarea
sysfillrect sysimgblt fb_sys_fops ttm drm virtio_pci
CPU: 2 PID: 5 Comm: kworker/u8:0 Not tainted 4.10.0-rc5-debug+ #3
Workqueue: iscsi_q_0 iscsi_xmitworker [libiscsi]
RIP: 0010:iscsi_tcp_segment_done+0x20b/0x310 [libiscsi_tcp]
Call Trace:
iscsi_sw_tcp_xmit_segment+0x84/0x120 [iscsi_tcp]
iscsi_sw_tcp_pdu_xmit+0x51/0x180 [iscsi_tcp]
iscsi_tcp_task_xmit+0xb3/0x290 [libiscsi_tcp]
iscsi_xmit_task+0x4e/0xc0 [libiscsi]
iscsi_xmitworker+0x243/0x330 [libiscsi]
process_one_work+0x1d8/0x4b0
worker_thread+0x49/0x4a0
kthread+0x102/0x140
Fixes: f80de881d8 ("sd: remove __data_len hack for WRITE SAME")
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Jens Axboe <axboe@fb.com>
Cc: Lee Duncan <lduncan@suse.com>
Cc: Chris Leech <cleech@redhat.com>
Acked-by: Christoph Hellwig <hch@lst.de>
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
2017-01-26 10:01:20 -07:00
..
2017-01-06 14:36:30 +01:00
2016-12-13 15:30:50 -08:00
2016-12-24 11:46:01 -08:00
2017-01-11 09:27:30 +01:00
2017-01-14 14:09:03 +01:00
2017-01-19 14:31:50 -07:00
2016-12-16 10:24:44 -08:00
2016-12-25 10:47:44 +01:00
2016-12-24 11:46:01 -08:00
2017-01-19 23:46:31 +02:00
2017-01-21 18:46:45 -08:00
2017-01-17 10:08:38 +01:00
2017-01-06 14:34:52 +01:00
2016-12-24 11:46:01 -08:00
2016-12-27 17:51:36 -08:00
2016-12-18 15:49:10 -08:00
2017-01-03 00:21:45 +01:00
2016-12-24 11:46:01 -08:00
2017-01-13 12:14:28 +05:30
2016-12-24 11:46:01 -08:00
2017-01-11 09:11:39 +01:00
2017-01-15 10:54:39 -08:00
2017-01-19 09:57:20 +01:00
2017-01-23 09:25:53 +10:00
2017-01-19 14:19:25 +01:00
2016-12-25 11:04:12 +01:00
2017-01-02 10:15:28 -08:00
2016-12-25 10:47:44 +01:00
2017-01-12 20:52:12 +01:00
2016-12-24 11:46:01 -08:00
2016-12-13 10:41:53 -08:00
2017-01-02 16:59:44 +01:00
2016-12-29 14:17:40 -05:00
2017-01-13 11:49:34 -08:00
2017-01-06 10:49:36 -08:00
2016-12-25 14:30:04 -08:00
2016-12-24 11:46:01 -08:00
2016-12-25 10:47:44 +01:00
2016-12-24 11:46:01 -08:00
2016-12-13 12:11:01 -08:00
2016-12-24 11:46:01 -08:00
2016-12-25 17:21:22 +01:00
2017-01-09 13:58:10 -08:00
2016-12-25 17:21:22 +01:00
2016-12-13 10:19:16 -08:00
2016-12-24 11:46:01 -08:00
2016-12-19 08:16:26 -08:00
2017-01-11 07:43:57 +01:00
2017-01-16 16:17:42 +01:00
2017-01-04 20:50:18 +01:00
2017-01-16 15:08:29 -05:00
2016-12-23 16:11:07 -05:00
2016-12-24 11:46:01 -08:00
2017-01-13 09:50:33 -08:00
2017-01-26 17:49:14 +02:00
2017-01-04 18:22:47 +01:00
2016-12-15 12:46:48 -08:00
2016-12-24 11:46:01 -08:00
2016-12-24 11:46:01 -08:00
2016-12-24 11:46:01 -08:00
2017-01-17 08:41:51 -06:00
2016-12-12 18:55:06 -08:00
2016-12-25 10:47:44 +01:00
2016-12-14 10:49:33 -08:00
2016-12-30 14:27:42 +01:00
2016-12-28 12:38:10 +02:00
2016-12-24 11:46:01 -08:00
2016-12-25 17:21:22 +01:00
2016-11-30 23:41:33 +01:00
2016-12-12 19:56:15 -08:00
2016-12-15 11:45:13 -08:00
2016-12-19 08:16:26 -08:00
2016-12-30 03:26:31 -08:00
2016-12-15 16:03:25 -08:00
2016-12-30 03:12:11 -08:00
2016-12-25 17:21:22 +01:00
2017-01-19 23:46:34 +02:00
2016-12-24 11:46:01 -08:00
2017-01-26 10:01:20 -07:00
2016-12-12 18:55:08 -08:00
2017-01-12 13:37:49 -08:00
2017-01-20 12:25:11 -08:00
2017-01-03 17:11:50 +01:00
2017-01-10 08:41:30 -08:00
2017-01-20 16:24:54 +08:00
2016-12-13 12:11:01 -08:00
2017-01-11 09:22:54 +01:00
2016-12-10 14:57:58 +01:00
2017-01-20 14:55:20 +01:00
2017-01-13 08:23:33 -07:00
2017-01-19 23:46:30 +02:00
2017-01-04 12:58:45 +01:00
2016-12-16 00:13:39 +02:00
2017-01-11 10:42:16 +01:00
2016-12-24 11:27:45 -08:00
2017-01-19 09:38:27 -08:00
2016-12-24 11:46:01 -08:00