1
0
Files
linux/kernel
Manfred Spraul 3ba35573ad kernel/cpu.c: Move the CPU_DYING notifiers
When a cpu is taken offline, the CPU_DYING notifiers are called on the
dying cpu. According to <linux/notifiers.h>, the cpu should be "not
running any task, not handling interrupts, soon dead".

For the current implementation, this is not true:
- __cpu_disable can fail. If it fails, then the cpu will remain alive
  and happy.
- At least on x86, __cpu_disable() briefly enables the local interrupts
  to handle any outstanding interrupts.

What about moving CPU_DYING down a few lines, behind the __cpu_disable()
line?
There are only two CPU_DYING handlers in the kernel right now: one in
kvm, one in the scheduler. Both should work with the patch applied
[and: I'm not sure if either one handles a failing __cpu_disable()]

The patch survives simple offlining a cpu. kvm untested due to lack
of a test setup.

Signed-off-By: Manfred Spraul <manfred@colorfullife.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2008-09-06 19:13:59 +02:00
..
2008-09-05 18:14:08 +02:00
2008-07-28 23:32:00 +02:00
2008-05-01 08:03:59 -07:00
2008-07-26 20:53:20 -04:00
2008-09-05 18:14:35 +02:00
2008-07-28 16:30:21 -07:00
2008-03-30 14:18:41 -07:00
2008-07-28 14:37:38 +02:00
2008-08-01 08:39:35 -05:00
2008-07-26 12:00:09 -07:00
2008-08-13 12:55:10 +02:00
2008-09-02 19:21:40 -07:00
2008-08-25 17:39:57 +02:00
2008-08-28 13:42:38 +02:00
2008-09-06 16:51:57 +02:00
2008-08-19 20:37:07 -07:00
2008-07-25 10:53:45 -07:00
2008-04-30 08:29:53 -07:00