Ming Lei
737f98cfe7
blk-mq: initialize mq kobjects in blk_mq_init_allocated_queue()
Both q->mq_kobj and sw queues' kobjects should have been initialized
once, instead of doing that each add_disk context.
Also this patch removes clearing of ctx in blk_mq_init_cpu_queues()
because percpu allocator fills zero to allocated variable.
This patch fixes one issue[1] reported from Omar.
[1] kernel wearning when doing unbind/bind on one scsi-mq device
[ 19.347924] kobject (ffff8800791ea0b8): tried to init an initialized object, something is seriously wrong.
[ 19.349781] CPU: 1 PID: 84 Comm: kworker/u8:1 Not tainted 4.10.0-rc7-00210-g53f39eeaa263 #34
[ 19.350686] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.1-20161122_114906-anatol 04/01/2014
[ 19.350920] Workqueue: events_unbound async_run_entry_fn
[ 19.350920] Call Trace:
[ 19.350920] dump_stack+0x63/0x83
[ 19.350920] kobject_init+0x77/0x90
[ 19.350920] blk_mq_register_dev+0x40/0x130
[ 19.350920] blk_register_queue+0xb6/0x190
[ 19.350920] device_add_disk+0x1ec/0x4b0
[ 19.350920] sd_probe_async+0x10d/0x1c0 [sd_mod]
[ 19.350920] async_run_entry_fn+0x48/0x150
[ 19.350920] process_one_work+0x1d0/0x480
[ 19.350920] worker_thread+0x48/0x4e0
[ 19.350920] kthread+0x101/0x140
[ 19.350920] ? process_one_work+0x480/0x480
[ 19.350920] ? kthread_create_on_node+0x60/0x60
[ 19.350920] ret_from_fork+0x2c/0x40
Cc: Omar Sandoval <osandov@osandov.com>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Tested-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
2017-03-08 09:56:12 -07:00
..
2017-01-17 09:02:31 -07:00
2016-10-21 15:45:47 -06:00
2016-10-28 08:45:17 -06:00
2017-02-24 14:42:19 -08:00
2017-03-02 08:42:32 +01:00
2017-03-02 16:08:35 -07:00
2017-01-31 14:00:34 -07:00
2017-02-17 12:35:47 -07:00
2017-02-02 08:20:48 -07:00
2017-03-03 10:53:35 -08:00
2017-02-06 09:34:46 -07:00
2017-03-02 08:42:36 +01:00
2017-02-08 13:43:08 -07:00
2016-11-08 17:30:00 -05:00
2017-02-02 10:20:16 -07:00
2016-09-19 08:21:51 -06:00
2017-03-02 08:56:04 -07:00
2017-02-23 11:55:47 -07:00
2017-03-08 09:56:12 -07:00
2017-03-02 08:56:04 -07:00
2017-03-02 08:56:04 -07:00
2017-02-27 20:54:05 +02:00
2017-03-08 09:56:12 -07:00
2017-03-08 09:56:12 -07:00
2017-02-08 13:43:08 -07:00
2017-03-02 08:42:26 +01:00
2016-12-09 13:08:35 -07:00
2016-11-10 13:53:26 -07:00
2017-03-02 13:59:08 -07:00
2017-01-17 10:04:20 -07:00
2017-02-27 18:43:47 -08:00
2015-12-22 09:38:34 -07:00
2017-02-02 08:20:48 -07:00
2016-11-28 10:27:03 -07:00
2017-01-12 07:58:32 -07:00
2017-02-08 13:43:08 -07:00
2015-09-19 18:57:09 -07:00
2017-01-27 15:08:35 -07:00
2017-02-27 18:43:47 -08:00
2017-03-02 08:42:27 +01:00
2017-02-02 08:21:32 -07:00
2017-02-08 13:43:06 -07:00
2017-03-02 13:59:08 -07:00
2017-03-02 16:08:35 -07:00
2017-02-02 08:21:32 -07:00
2017-03-02 08:42:38 +01:00
2017-03-02 13:53:13 -08:00
2017-02-22 13:19:45 -07:00
2017-03-02 13:53:13 -08:00
2017-02-08 13:43:06 -07:00
2017-01-17 10:03:33 -07:00
2017-02-17 12:41:47 -07:00
2017-01-12 07:58:32 -07:00
2017-01-31 14:00:44 -07:00
2017-02-23 11:55:44 -07:00
2015-10-21 14:42:38 -06:00