sugar/linux
1
0
Fork 0
Code Activity
Files
8e60029f403781b8a63b7ffdb7dc1faff6ca651e
linux/fs
History
Jeff Layton 8e60029f40 NFS: fix reference counting for NFSv4 callback thread 
The reference counting for the NFSv4 callback thread stays artificially
high. When this thread comes down, it doesn't properly tear down the
svc_serv, causing a memory leak. In my testing on an older kernel on
x86_64, memory would leak out of the 8k kmalloc slab. So, we're leaking
at least a page of memory every time the thread comes down.

svc_create() creates the svc_serv with a sv_nrthreads count of 1, and
then svc_create_thread() increments that count. Whenever the callback
thread is started it has a sv_nrthreads count of 2. When coming down, it
calls svc_exit_thread() which decrements that count and if it hits 0, it
tears everything down. That never happens here since the count is always
at 2 when the thread exits.

The problem is that nfs_callback_up() should be calling svc_destroy() on
the svc_serv on both success and failure. This is how lockd_up_proto()
handles the reference counting, and doing that here fixes the leak.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
2008-02-13 23:24:04 -05:00
..
9p
Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p)
2008-02-07 08:42:26 -08:00
adfs
mount options: fix adfs
2008-02-08 09:22:39 -08:00
affs
mount options: fix affs
2008-02-08 09:22:39 -08:00
afs
mount options: fix afs
2008-02-08 09:22:39 -08:00
autofs
mount options: fix autofs
2008-02-08 09:22:40 -08:00
autofs4
mount options: fix autofs4
2008-02-08 09:22:39 -08:00
befs
mount options: fix befs
2008-02-08 09:22:40 -08:00
bfs
iget: stop BFS from using iget() and read_inode()
2008-02-07 08:42:27 -08:00
cifs
Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user
2008-02-05 09:44:13 -08:00
coda
coda: convert struct class_device to struct device
2008-01-24 20:40:05 -08:00
configfs
configfs: file.c fix possible recursive locking
2008-01-25 15:05:47 -08:00
cramfs
fs/cramfs/inode.c: replace hardcoded value with preprocessor constant
2007-10-18 14:37:29 -07:00
debugfs
libfs: allow error return from simple attributes
2008-02-08 09:22:34 -08:00
devpts
mount options: fix devpts
2008-02-08 09:22:40 -08:00
dlm
dlm: add __init and __exit marks to init and exit functions
2008-02-06 23:41:22 -06:00
ecryptfs
Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user
2008-02-05 09:44:13 -08:00
efs
iget: stop EFS from using iget() and read_inode()
2008-02-07 08:42:27 -08:00
exportfs
exportfs: update documentation
2007-10-22 08:13:21 -07:00
ext2
mount options: fix ext2
2008-02-08 09:22:40 -08:00
ext3
Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user
2008-02-05 09:44:13 -08:00
ext4
ext4: Add new "development flag" to the ext4 filesystem
2008-02-10 01:11:44 -05:00
fat
mount options: fix fat
2008-02-08 09:22:40 -08:00
freevxfs
iget: stop FreeVXFS from using iget() and read_inode()
2008-02-07 08:42:28 -08:00
fuse
mount options: fix fuse
2008-02-08 09:22:40 -08:00
gfs2
Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user
2008-02-05 09:44:13 -08:00
hfs
hfs: update comment to reflect actual init and exit routines
2008-02-06 10:41:05 -08:00
hfsplus
fs/hfsplus/unicode.c: fix uninitialized var warning
2008-02-08 09:22:36 -08:00
hostfs
uml: fix hostfs tv_usec calculations
2008-02-05 09:44:30 -08:00
hpfs
mount options: fix hpfs
2008-02-08 09:22:40 -08:00
hppfs
iget: stop HPPFS from using iget() and read_inode()
2008-02-07 08:42:29 -08:00
hugetlbfs
hugetlb: allow sticky directory mount option
2008-02-05 09:44:14 -08:00
isofs
mount options: fix isofs
2008-02-08 09:22:40 -08:00
jbd
ext3 can fail badly when device stops accepting BIO_RW_BARRIER requests
2008-02-08 09:22:44 -08:00
jbd2
JBD2: Clear buffer_ordered flag for barried IO request on success
2008-02-10 01:09:32 -05:00
jffs2
Merge git://git.infradead.org/mtd-2.6
2008-02-07 10:20:31 -08:00
jfs
BKL-removal: Implement a compat_ioctl handler for JFS
2008-02-07 13:45:29 -06:00
lockd
NLM: don't requeue block if it was invalidated while GRANT_MSG was in flight
2008-02-10 18:09:36 -05:00
minix
iget: stop the MINIX filesystem from using iget() and read_inode()
2008-02-07 08:42:28 -08:00
msdos
…
ncpfs
mount options: fix ncpfs
2008-02-08 09:22:40 -08:00
nfs
NFS: fix reference counting for NFSv4 callback thread
2008-02-13 23:24:04 -05:00
nfs_common
…
nfsd
Add 64-bit capability support to the kernel
2008-02-05 09:44:20 -08:00
nls
sparse pointer use of zero as null
2007-10-18 14:37:31 -07:00
ntfs
is_vmalloc_addr(): Check if an address is within the vmalloc boundaries
2008-02-05 09:44:14 -08:00
ocfs2
Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user
2008-02-05 09:44:13 -08:00
openpromfs
iget: stop OPENPROMFS from using iget() and read_inode()
2008-02-07 08:42:29 -08:00
partitions
Enhanced partition statistics: remove old partition statistics
2008-02-08 12:42:01 +01:00
proc
Add 64-bit capability support to the kernel
2008-02-05 09:44:20 -08:00
qnx4
iget: stop QNX4 from using iget() and read_inode()
2008-02-07 08:42:28 -08:00
ramfs
Remove valueless definition of hard-selected RAMFS option
2007-10-17 08:42:56 -07:00
reiserfs
Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user
2008-02-05 09:44:13 -08:00
romfs
iget: stop ROMFS from using iget() and read_inode()
2008-02-07 08:42:28 -08:00
smbfs
fs/smbfs/inode.c: fix warning message deprecating smbfs
2008-02-13 16:21:19 -08:00
sysfs
sysfs: remove BUG_ON() from sysfs_remove_group()
2008-02-07 11:31:46 -08:00
sysv
iget: stop the SYSV filesystem from using iget() and read_inode()
2008-02-07 08:42:29 -08:00
udf
udf: fix udf_add_free_space
2008-02-13 16:21:20 -08:00
ufs
drop linux/ufs_fs.h from userspace export and relocate it to fs/ufs/ufs_fs.h
2008-02-08 09:22:39 -08:00
vfat
Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p)
2008-02-07 08:42:26 -08:00
xfs
xfs: convert beX_add to beX_add_cpu (new common API)
2008-02-13 16:21:19 -08:00
aio.c
aio: negative offset should return -EINVAL
2008-02-08 09:22:33 -08:00
anon_inodes.c
anon-inodes use open coded atomic_inc for the shared inode
2007-10-17 08:43:00 -07:00
attr.c
VFS: make notify_change pass ATTR_KILL_S*ID to setattr operations
2007-10-18 14:37:22 -07:00
bad_inode.c
iget: introduce a function to register iget failure
2008-02-07 08:42:26 -08:00
binfmt_aout.c
aout: suppress A.OUT library support if !CONFIG_ARCH_SUPPORTS_AOUT
2008-02-08 09:22:30 -08:00
binfmt_elf_fdpic.c
pid namespaces: changes to show virtual ids to user
2007-10-19 11:53:40 -07:00
binfmt_elf.c
Remove a.out interpreter support in ELF loader
2008-02-08 09:22:41 -08:00
binfmt_em86.c
Convert files to UTF-8 and some cleanups
2007-10-19 23:21:04 +02:00
binfmt_flat.c
aout: remove unnecessary inclusions of {asm, linux}/a.out.h
2008-02-08 09:22:30 -08:00
binfmt_misc.c
Convert files to UTF-8 and some cleanups
2007-10-19 23:21:04 +02:00
binfmt_script.c
Convert files to UTF-8 and some cleanups
2007-10-19 23:21:04 +02:00
binfmt_som.c
aout: remove unnecessary inclusions of {asm, linux}/a.out.h
2008-02-08 09:22:30 -08:00
bio.c
__bio_clone: don't calculate hw/phys segment counts
2008-01-28 10:04:46 +01:00
block_dev.c
kill an unused PTR_ERR in bdev_cache_init()
2008-02-06 10:41:06 -08:00
buffer.c
bufferhead: revert constructor removal
2008-02-05 09:44:14 -08:00
char_dev.c
fs/char_dev.c: chrdev_open marked static and removed from fs.h
2008-02-08 09:22:42 -08:00
compat_binfmt_elf.c
x86: compat_binfmt_elf
2008-01-30 13:31:46 +01:00
compat_ioctl.c
dm ioctl: move compat code
2008-02-08 02:09:56 +00:00
compat.c
timerfd: new timerfd API
2008-02-05 09:44:07 -08:00
dcache.c
inotify: remove debug code
2008-02-06 10:41:07 -08:00
dcookies.c
Remove fs.h from mm.h
2007-07-29 17:09:29 -07:00
direct-io.c
Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user
2008-02-05 09:44:13 -08:00
dnotify.c
mm: Remove slab destructors from kmem_cache_create().
2007-07-20 10:11:58 +09:00
dquot.c
quota: improve inode list scanning in add_dquot_ref()
2008-02-06 10:41:07 -08:00
drop_caches.c
…
eventfd.c
fs/eventfd.c should #include <linux/syscalls.h>
2008-02-06 10:41:03 -08:00
eventpoll.c
lockdep: annotate epoll
2008-02-05 09:44:07 -08:00
exec.c
exec: rework the group exit and fix the race with kill
2008-02-05 09:44:07 -08:00
fcntl.c
fs: remove fastcall, it is always empty
2008-02-08 09:22:31 -08:00
fifo.c
…
file_table.c
fs: remove fastcall, it is always empty
2008-02-08 09:22:31 -08:00
file.c
get rid of NR_OPEN and introduce a sysctl_nr_open
2008-02-06 10:41:06 -08:00
filesystems.c
…
fs-writeback.c
writeback: speed up writeback of big dirty files
2008-02-05 09:44:19 -08:00
generic_acl.c
…
inode.c
iget: remove iget() and the read_inode() super op as being obsolete
2008-02-07 08:42:29 -08:00
inotify_user.c
inotify: fix check for one-shot watches before destroying them
2008-02-08 09:22:22 -08:00
inotify.c
inotify: remove debug code
2008-02-06 10:41:07 -08:00
internal.h
…
ioctl.c
fix up kerneldoc in fs/ioctl.c a little bit
2008-02-09 11:08:33 -08:00
ioprio.c
cfq-iosched: relax IOPRIO_CLASS_IDLE restrictions
2008-01-28 11:38:15 +01:00
Kconfig
deprecate smbfs in favour of cifs
2008-02-05 14:37:15 -08:00
Kconfig.binfmt
aout: suppress A.OUT library support if !CONFIG_ARCH_SUPPORTS_AOUT
2008-02-08 09:22:30 -08:00
libfs.c
Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user
2008-02-05 09:44:13 -08:00
locks.c
Pidns: make full use of xxx_vnr() calls
2008-02-08 09:22:29 -08:00
Makefile
x86: compat_binfmt_elf Kconfig
2008-01-30 13:31:46 +01:00
mbcache.c
fs: Fix to correct the mbcache entries counter
2007-10-25 15:18:29 -07:00
mpage.c
Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user
2008-02-05 09:44:13 -08:00
namei.c
fs: remove fastcall, it is always empty
2008-02-08 09:22:31 -08:00
namespace.c
reduce large do_mount stack usage with noinlines
2008-02-08 09:22:44 -08:00
nfsctl.c
…
no-block.c
…
open.c
remove the unused exports of sys_open/sys_read
2008-02-08 09:22:36 -08:00
pipe.c
kernel-doc: fix fs/pipe.c notation
2008-02-13 16:21:19 -08:00
pnode.c
MNT_UNBINDABLE fix
2008-02-06 10:41:02 -08:00
pnode.h
[PATCH] new helpers - collect_mounts() and release_collected_mounts()
2007-10-21 02:37:25 -04:00
posix_acl.c
…
quota_v1.c
…
quota_v2.c
…
quota.c
Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p)
2008-02-07 08:42:26 -08:00
read_write.c
remove the unused exports of sys_open/sys_read
2008-02-08 09:22:36 -08:00
read_write.h
…
readdir.c
Use mutex_lock_killable in vfs_readdir
2007-12-06 17:39:54 -05:00
select.c
make sys_poll() wait at least timeout ms
2008-02-06 10:41:09 -08:00
seq_file.c
[FS] seq_file: Introduce the seq_open_private()
2007-10-10 16:55:33 -07:00
signalfd.c
fs/signalfd.c should #include <linux/syscalls.h>
2008-02-06 10:41:03 -08:00
splice.c
splice: fix user pointer access in get_iovec_page_array()
2008-02-10 10:27:21 -08:00
stack.c
…
stat.c
…
super.c
quota: turn quotas off when remounting read-only
2008-02-08 09:22:44 -08:00
sync.c
…
timerfd.c
timerfd: new timerfd API
2008-02-05 09:44:07 -08:00
utimes.c
fs/utimes.c should #include <linux/syscalls.h>
2008-02-06 10:41:03 -08:00
xattr_acl.c
…
xattr.c
VFS: Reorder vfs_getxattr to avoid unnecessary calls to the LSM
2008-02-05 09:44:20 -08:00