Bart Van Assche 8c7a8d1c4b lib/scatterlist: Fix chaining support in sgl_alloc_order() ...

This patch avoids that workloads with large block sizes (megabytes)
can trigger the following call stack with the ib_srpt driver (that
driver is the only driver that chains scatterlists allocated by
sgl_alloc_order()):

BUG: Bad page state in process kworker/0:1H  pfn:2423a78
page:fffffb03d08e9e00 count:-3 mapcount:0 mapping:          (null) index:0x0
flags: 0x57ffffc0000000()
raw: 0057ffffc0000000 0000000000000000 0000000000000000 fffffffdffffffff
raw: dead000000000100 dead000000000200 0000000000000000 0000000000000000
page dumped because: nonzero _count
CPU: 0 PID: 733 Comm: kworker/0:1H Tainted: G          I      4.15.0-rc7.bart+ #1
Hardware name: HP ProLiant DL380 G7, BIOS P67 08/16/2015
Workqueue: ib-comp-wq ib_cq_poll_work [ib_core]
Call Trace:
 dump_stack+0x5c/0x83
 bad_page+0xf5/0x10f
 get_page_from_freelist+0xa46/0x11b0
 __alloc_pages_nodemask+0x103/0x290
 sgl_alloc_order+0x101/0x180
 target_alloc_sgl+0x2c/0x40 [target_core_mod]
 srpt_alloc_rw_ctxs+0x173/0x2d0 [ib_srpt]
 srpt_handle_new_iu+0x61e/0x7f0 [ib_srpt]
 __ib_process_cq+0x55/0xa0 [ib_core]
 ib_cq_poll_work+0x1b/0x60 [ib_core]
 process_one_work+0x141/0x340
 worker_thread+0x47/0x3e0
 kthread+0xf5/0x130
 ret_from_fork+0x1f/0x30

Fixes: e80a0af475 ("lib/scatterlist: Introduce sgl_alloc() and sgl_free()")
Reported-by: Laurence Oberman <loberman@redhat.com>
Tested-by: Laurence Oberman <loberman@redhat.com>
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Nicholas A. Bellinger <nab@linux-iscsi.org>
Cc: Laurence Oberman <loberman@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

2018-01-19 12:31:03 -07:00

..

iscsi

Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending

2017-11-24 19:19:20 -10:00

loopback

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

sbp

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

tcm_fc

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

Kconfig

target: Use sgl_alloc_order() and sgl_free()

2018-01-06 09:18:00 -07:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

target_core_alua.c

target: fix ALUA state file path truncation

2017-11-04 15:00:30 -07:00

target_core_alua.h

Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending

2017-11-24 19:19:20 -10:00

target_core_configfs.c

Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending

2017-11-24 19:19:20 -10:00

target_core_device.c

target: Fix cmd size for PR-OUT in passthrough_parse_cdb

2017-07-09 20:58:49 -07:00

target_core_fabric_configfs.c

target: Move a declaration of a global variable into a header file

2017-11-04 15:15:30 -07:00

target_core_fabric_lib.c

target: Use {get,put}_unaligned_be*() instead of open coding these functions

2017-07-06 22:57:59 -07:00

target_core_file.c

target/file: Do not return error for UNMAP if length is zero

2017-11-04 14:45:16 -07:00

target_core_file.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

target_core_hba.c

target: Fix target_sense_desc_format NULL pointer dereference

2015-09-24 23:17:23 -07:00

target_core_iblock.c

block: replace bi_bdev with a gendisk pointer and partitions index

2017-08-23 12:49:55 -06:00

target_core_iblock.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

target_core_internal.h

Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending

2017-11-24 19:19:20 -10:00

target_core_pr.c

target: Suppress gcc 7 fallthrough warnings

2017-11-04 15:15:35 -07:00

target_core_pr.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

target_core_pscsi.c

Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending

2017-07-13 14:27:32 -07:00

target_core_pscsi.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

target_core_rd.c

target: break up free_device callback

2017-07-06 23:11:37 -07:00

target_core_rd.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

target_core_sbc.c

Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending

2017-07-13 14:27:32 -07:00

target_core_spc.c

target: Fix cmd size for PR-OUT in passthrough_parse_cdb

2017-07-09 20:58:49 -07:00

target_core_stat.c

target: make config_item_type const

2017-10-19 16:15:17 +02:00

target_core_tmr.c

target: Avoid early CMD_T_PRE_EXECUTE failures during ABORT_TASK

2017-11-07 19:50:24 -08:00

target_core_tpg.c

target: Fix node_acl demo-mode + uncached dynamic shutdown regression

2017-08-09 20:55:19 -07:00

target_core_transport.c

lib/scatterlist: Fix chaining support in sgl_alloc_order()

2018-01-19 12:31:03 -07:00

target_core_ua.c

Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending

2015-07-04 14:13:43 -07:00

target_core_ua.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

target_core_user.c

Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

2017-11-25 08:37:16 -10:00

target_core_xcopy.c

xcopy: loop over devices using idr helper

2017-07-06 23:11:40 -07:00

target_core_xcopy.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00