Mel Gorman 0ee364eb31
x86/mm: Check if PUD is large when validating a kernel address ...
A user reported the following oops when a backup process reads
/proc/kcore:
BUG: unable to handle kernel paging request at ffffbb00ff33b000
IP: [<ffffffff8103157e>] kern_addr_valid+0xbe/0x110
[...]
Call Trace:
[<ffffffff811b8aaa>] read_kcore+0x17a/0x370
[<ffffffff811ad847>] proc_reg_read+0x77/0xc0
[<ffffffff81151687>] vfs_read+0xc7/0x130
[<ffffffff811517f3>] sys_read+0x53/0xa0
[<ffffffff81449692>] system_call_fastpath+0x16/0x1b
Investigation determined that the bug triggered when reading
system RAM at the 4G mark. On this system, that was the first
address using 1G pages for the virt->phys direct mapping so the
PUD is pointing to a physical address, not a PMD page.
The problem is that the page table walker in kern_addr_valid() is
not checking pud_large() and treats the physical address as if
it was a PMD. If it happens to look like pmd_none then it'll
silently fail, probably returning zeros instead of real data. If
the data happens to look like a present PMD though, it will be
walked resulting in the oops above.
This patch adds the necessary pud_large() check.
Unfortunately the problem was not readily reproducible and now
they are running the backup program without accessing
/proc/kcore so the patch has not been validated but I think it
makes sense.
Signed-off-by: Mel Gorman <mgorman@suse.de >
Reviewed-by: Rik van Riel <riel@redhat.coM >
Reviewed-by: Michal Hocko <mhocko@suse.cz >
Acked-by: Johannes Weiner <hannes@cmpxchg.org >
Cc: stable@vger.kernel.org
Cc: linux-mm@kvack.org
Link: http://lkml.kernel.org/r/20130211145236.GX21389@suse.de
Signed-off-by: Ingo Molnar <mingo@kernel.org >
2013-02-13 10:02:55 +01:00
2012-11-09 17:32:31 +08:00
2012-12-07 14:24:32 -07:00
2013-01-24 15:58:54 +01:00
2012-12-13 14:29:16 -08:00
2012-05-30 10:12:48 -07:00
2012-09-21 12:45:26 -07:00
2012-10-01 13:59:17 -07:00
2012-06-07 12:43:44 +02:00
2011-07-23 10:34:47 -07:00
2011-12-05 17:17:07 +01:00
2012-10-06 03:04:40 +09:00
2012-05-18 09:46:07 +02:00
2011-07-31 14:02:19 -07:00
2012-04-20 17:22:34 -07:00
2012-05-09 11:38:20 +02:00
2011-08-29 13:44:12 -07:00
2012-11-29 13:23:02 -08:00
2012-03-28 18:11:12 +01:00
2011-04-29 14:13:15 -07:00
2012-09-19 17:26:08 +02:00
2012-12-14 22:37:13 +00:00
2012-03-28 18:11:12 +01:00
2012-03-28 18:11:12 +01:00
2012-10-02 18:01:25 +01:00
2011-03-14 15:13:23 +01:00
2012-10-02 18:01:25 +01:00
2012-11-27 23:29:09 -02:00
2012-11-29 13:23:01 -08:00
2012-01-04 15:01:54 +01:00
2012-10-02 18:01:25 +01:00
2012-10-06 03:05:16 +09:00
2012-11-30 11:40:07 -08:00
2012-01-26 16:44:41 -08:00
2012-11-14 15:28:11 -08:00
2012-12-13 15:31:08 -08:00
2012-05-14 14:15:31 -07:00
2012-12-14 22:37:13 +00:00
2011-07-22 18:46:24 +02:00
2012-05-14 14:15:31 -07:00
2012-11-15 00:28:00 +01:00
2011-12-05 18:16:11 +01:00
2012-05-21 15:09:38 +02:00
2012-10-24 17:06:43 +02:00
2011-05-02 17:24:48 +02:00
2011-09-28 19:04:52 +02:00
2012-12-14 22:37:13 +00:00
2013-01-30 11:51:59 -08:00
2012-12-11 17:22:25 -08:00
2012-06-17 10:51:01 -07:00
2012-06-27 19:29:13 -07:00
2012-03-28 18:11:12 +01:00
2012-11-27 23:29:09 -02:00
2012-06-06 09:17:22 +02:00
2012-11-30 13:48:05 -08:00
2011-07-21 09:03:31 +02:00
2012-08-23 11:26:36 -04:00
2012-11-29 13:23:02 -08:00
2011-04-18 09:26:48 -07:00
2012-05-11 18:00:14 -06:00
2012-09-27 22:52:34 -07:00
2012-03-20 21:48:30 +08:00
2012-09-01 08:44:28 -07:00
2012-10-09 16:22:24 +09:00
2012-12-14 22:37:13 +00:00
2011-09-21 10:22:03 +02:00
2012-07-11 19:33:32 +03:00
2012-09-21 16:59:04 -07:00
2010-10-12 16:53:36 +02:00
2011-11-17 13:35:37 -08:00
2012-12-19 18:07:41 -05:00
2012-03-26 03:16:07 +02:00
2012-02-11 15:11:35 +01:00
2011-11-11 10:22:55 +01:00
2012-02-11 15:11:35 +01:00
2011-12-05 12:42:11 +01:00
2012-05-01 14:50:09 -04:00
2011-08-03 22:00:38 -10:00
2010-10-26 16:52:08 -07:00
2012-09-05 10:52:26 +02:00
2012-06-25 13:48:30 +02:00
2011-01-28 14:54:05 +01:00
2012-05-14 14:15:31 -07:00
2012-05-08 11:17:29 +02:00
2012-06-27 19:29:13 -07:00
2011-02-23 22:27:52 +01:00
2011-07-07 19:22:32 +02:00
2012-12-14 22:37:13 +00:00
2012-02-24 10:05:59 +01:00
2012-05-08 14:19:41 -07:00
2012-12-14 22:37:13 +00:00
2012-05-09 11:44:42 +02:00
2012-12-11 19:55:23 -02:00
2012-03-22 15:07:15 -05:00
2012-07-31 10:29:59 -04:00
2012-09-06 18:07:38 +03:00
2012-11-27 23:29:10 -02:00
2012-11-30 18:29:30 -02:00
2012-12-14 22:37:13 +00:00
2011-07-22 14:39:50 +09:30
2011-05-24 14:33:35 +02:00
2012-11-29 13:23:02 -08:00
2011-11-21 19:00:57 -08:00
2011-11-10 16:21:01 +01:00
2012-03-28 18:11:12 +01:00
2013-01-09 14:49:02 +01:00
2012-08-22 16:15:58 -07:00
2012-05-14 14:15:31 -07:00
2011-05-25 16:16:41 +02:00
2012-04-14 14:28:58 +02:00
2011-06-27 14:13:09 -07:00
2012-10-02 18:01:25 +01:00
2012-11-29 13:23:01 -08:00
2012-05-17 19:06:13 -04:00
2012-05-17 19:06:13 -04:00
2010-11-11 11:34:27 +01:00
2012-01-26 21:23:53 +01:00
2012-12-14 22:37:13 +00:00
2012-12-14 22:37:13 +00:00
2012-10-02 18:01:25 +01:00
2010-09-17 15:36:40 -07:00
2012-06-20 14:23:17 +02:00
2012-04-19 15:07:42 -07:00
2011-05-02 14:18:53 +02:00
2011-05-02 14:18:53 +02:00
2012-10-02 18:01:25 +01:00
2011-05-02 14:18:53 +02:00
2011-03-15 14:17:23 -07:00
2012-07-31 23:27:30 -04:00
2012-05-08 14:08:44 +02:00
2012-05-08 14:08:44 +02:00
2012-03-28 18:30:03 +01:00
2012-07-26 13:17:17 -07:00
2012-12-18 09:49:03 -08:00
2013-01-03 15:57:04 -08:00
2013-01-03 15:57:04 -08:00
2012-12-05 14:33:26 -07:00
2012-11-29 13:23:01 -08:00
2011-07-21 20:41:54 +02:00
2012-08-10 11:44:06 -03:00
2010-11-01 15:38:34 -04:00
2012-10-09 16:23:05 +09:00
2012-10-09 16:23:05 +09:00
2012-12-11 14:28:35 +00:00
2012-06-06 09:17:22 +02:00
2012-07-22 12:04:44 -07:00
2013-02-13 10:02:55 +01:00
2012-12-14 22:37:13 +00:00
2011-03-15 15:34:15 -07:00
2012-12-14 22:37:13 +00:00
2012-12-12 12:22:13 -08:00
2012-02-23 14:37:47 -07:00
2012-12-20 18:05:28 -08:00
2012-04-08 12:48:57 +03:00
2012-11-27 23:29:09 -02:00
2012-06-17 10:51:01 -07:00
2012-06-17 10:51:01 -07:00
2011-07-21 09:03:36 +02:00
2011-08-29 13:44:12 -07:00
2012-10-02 18:01:25 +01:00
2012-04-19 15:42:45 -07:00
2012-12-14 22:37:13 +00:00
2012-12-14 22:37:13 +00:00
2012-02-20 12:52:05 -08:00
2012-06-01 12:58:51 -04:00
2012-12-19 18:07:39 -05:00
2012-09-21 12:45:27 -07:00
2012-11-14 09:39:48 -08:00
2011-07-21 09:20:59 +02:00
2012-03-28 18:11:12 +01:00
2012-02-07 10:09:54 +01:00
2012-08-22 09:52:47 +02:00
2012-05-09 15:34:28 +02:00
2012-05-14 14:15:31 -07:00
2011-05-12 15:31:28 +02:00
2012-10-02 18:01:25 +01:00
2011-05-24 23:35:55 +02:00
2011-05-24 23:35:55 +02:00
2012-10-02 18:01:25 +01:00
2012-12-14 22:37:13 +00:00
2012-03-28 18:11:12 +01:00
2012-12-19 18:07:41 -05:00
2012-04-14 11:13:20 +10:00
2012-12-19 18:07:40 -05:00
2012-10-10 12:02:25 +09:00
2011-06-09 15:01:40 +02:00
2012-03-13 16:27:51 +01:00
2012-06-27 19:29:11 -07:00
2012-11-29 13:23:02 -08:00
2012-05-09 15:00:55 +02:00
2012-11-13 15:48:40 -05:00
2012-03-09 16:47:54 -08:00
2012-03-20 12:37:45 +02:00
2012-09-21 12:45:26 -07:00
2012-09-21 12:45:26 -07:00
2012-11-29 13:23:03 -08:00
2012-12-20 18:05:28 -08:00
2012-09-15 17:37:32 +02:00
2012-10-02 18:01:25 +01:00
2012-09-05 10:52:23 +02:00
2012-04-24 09:50:18 +01:00
2012-09-24 12:38:09 -04:00
2012-03-28 18:11:12 +01:00
2012-12-14 22:37:13 +00:00
2012-12-14 22:37:13 +00:00
2012-12-14 22:37:13 +00:00
2011-06-05 21:30:32 +02:00
2012-05-26 11:33:40 -07:00
2012-06-06 10:22:17 +02:00
2012-09-12 15:33:07 +02:00
2012-10-02 18:01:25 +01:00
2012-10-02 18:01:25 +01:00
2012-09-18 15:52:08 -07:00
2012-10-02 18:01:25 +01:00
2012-09-21 17:18:44 -07:00
0ee364eb31