Elena Reshetova cff7cb2ece
fs, nfsd: convert nfs4_cntl_odstate.co_odcount from atomic_t to refcount_t ...
atomic_t variables are currently used to implement reference
counters with the following properties:
- counter is initialized to 1 using atomic_set()
- a resource is freed upon counter reaching zero
- once counter reaches zero, its further
increments aren't allowed
- counter schema uses basic atomic operations
(set, inc, inc_not_zero, dec_and_test, etc.)
Such atomic variables should be converted to a newly provided
refcount_t type and API that prevents accidental counter overflows
and underflows. This is important since overflows and underflows
can lead to use-after-free situation and be exploitable.
The variable nfs4_cntl_odstate.co_odcount is used as pure reference counter.
Convert it to refcount_t and fix up the operations.
Suggested-by: Kees Cook <keescook@chromium.org >
Reviewed-by: David Windsor <dwindsor@gmail.com >
Reviewed-by: Hans Liljestrand <ishkamiel@gmail.com >
Signed-off-by: Elena Reshetova <elena.reshetova@intel.com >
Signed-off-by: J. Bruce Fields <bfields@redhat.com >
2017-11-07 16:43:59 -05:00
2017-09-06 20:49:49 -07:00
2017-09-14 18:54:01 -07:00
2017-09-06 20:49:49 -07:00
2017-09-14 18:13:32 -07:00
2017-07-17 08:45:34 +01:00
2017-07-12 16:26:00 -07:00
2017-09-14 19:29:55 -07:00
2017-07-17 08:45:34 +01:00
2017-09-12 20:03:53 -07:00
2017-09-07 16:06:14 -07:00
2017-09-04 19:05:15 -04:00
2017-08-23 12:49:55 -06:00
2017-07-15 12:00:42 -07:00
2017-08-24 13:23:03 -07:00
2017-09-06 13:43:26 -07:00
2017-09-14 18:54:01 -07:00
2017-07-11 06:09:21 -04:00
2017-07-17 08:45:34 +01:00
2017-09-07 11:59:42 -07:00
2017-09-14 18:54:01 -07:00
2017-09-14 19:29:55 -07:00
2017-09-12 20:05:58 -07:00
2017-09-14 18:54:01 -07:00
2017-09-13 18:53:15 -07:00
2017-09-13 10:10:19 -07:00
2017-09-14 18:54:01 -07:00
2017-09-14 18:54:01 -07:00
2017-09-14 18:54:01 -07:00
2017-08-01 08:39:29 -04:00
2017-09-14 18:54:01 -07:00
2017-09-08 18:26:49 -07:00
2017-09-14 18:54:01 -07:00
2017-07-07 19:38:17 -07:00
2017-09-14 18:54:01 -07:00
2017-09-14 18:54:01 -07:00
2017-09-07 11:59:42 -07:00
2017-11-07 16:43:58 -05:00
2017-07-17 08:45:34 +01:00
2017-08-01 08:39:29 -04:00
2017-09-14 20:04:32 -07:00
2017-09-26 09:25:38 -04:00
2017-11-07 16:43:59 -05:00
2017-09-14 18:54:01 -07:00
2017-08-30 16:02:48 +02:00
2017-09-14 18:54:01 -07:00
2017-09-14 18:54:01 -07:00
2017-07-06 03:31:46 -04:00
2017-09-14 14:58:31 -04:00
2017-09-14 18:54:01 -07:00
2017-09-13 18:53:16 -07:00
2017-08-17 16:29:19 -07:00
2017-09-14 18:54:01 -07:00
2017-09-06 17:27:26 -07:00
2017-09-14 18:54:01 -07:00
2017-09-08 19:33:25 -07:00
2017-07-17 08:45:34 +01:00
2017-07-06 03:31:46 -04:00
2017-09-14 18:54:01 -07:00
2017-09-14 18:54:01 -07:00
2017-07-17 08:45:34 +01:00
2017-09-14 19:29:55 -07:00
2017-09-14 19:29:55 -07:00
2017-09-04 19:05:15 -04:00
2017-09-14 18:13:32 -07:00
2017-09-14 18:13:32 -07:00
2017-09-14 18:13:32 -07:00
2017-09-04 19:05:15 -04:00
2017-09-14 19:29:55 -07:00
2017-09-07 11:59:42 -07:00
2017-07-17 15:28:50 +02:00
2017-09-05 08:25:07 -04:00
2017-09-13 18:53:16 -07:00
2017-09-14 13:43:16 -07:00
2017-07-15 12:00:42 -07:00
2017-08-23 12:49:55 -06:00
2017-07-03 21:13:25 -07:00
2017-09-08 18:26:49 -07:00
2017-09-14 20:18:45 -07:00
2017-07-24 14:29:23 -05:00
2017-08-28 00:50:23 -04:00
2017-07-06 16:24:30 -07:00
2017-07-15 12:00:42 -07:00
2017-07-12 16:26:05 -07:00
2017-09-13 09:11:44 -07:00
2017-09-13 09:11:44 -07:00
2017-09-07 11:59:42 -07:00
2017-07-12 16:26:00 -07:00
2017-07-06 07:02:29 -04:00
2017-07-21 13:57:31 -04:00
2017-07-19 08:55:18 -07:00
2017-08-23 12:49:55 -06:00
2017-09-14 18:54:01 -07:00
2017-09-14 20:01:41 -07:00
2017-07-06 03:27:09 -04:00
2017-09-05 12:53:12 +02:00
2017-07-06 03:27:09 -04:00
2017-07-17 08:45:34 +01:00
2017-09-14 18:13:32 -07:00
2017-08-28 16:09:19 -07:00
2017-07-24 14:30:28 -05:00
2017-09-04 19:05:15 -04:00
2017-08-17 22:06:03 +02:00
2017-07-08 10:50:54 -07:00
2017-09-14 18:54:01 -07:00
2017-09-14 18:54:01 -07:00
2017-06-30 04:14:38 -04:00
2017-09-08 18:26:47 -07:00
2017-09-03 20:24:30 -04:00
2017-09-13 09:11:44 -07:00
cff7cb2ece