1
0
Files
linux/arch/x86/kernel
Miquel van Smoorenburg db9f600b96 x86: pci-dma.c: use __GFP_NO_OOM instead of __GFP_NORETRY
On Wed, 2008-05-28 at 04:47 +0200, Andi Kleen wrote:
> > So...  why not just remove the setting of __GFP_NORETRY?  Why is it
> > wrong to oom-kill things in this case?
>
> When the 16MB zone overflows (which can be common in some workloads)
> calling the OOM killer is pretty useless because it has barely any
> real user data [only exception would be the "only 16MB" case Alan
> mentioned]. Killing random processes in this case is bad.
>
> I think for 16MB __GFP_NORETRY is ok because there should be
> nothing freeable in there so looping is useless. Only exception would be the
> "only 16MB total" case again but I'm not sure 2.6 supports that at all
> on x86.
>
> On the other hand d_a_c() does more allocations than just 16MB, especially
> on 64bit and the other zones need different strategies.

Okay, so how about this then ?

Signed-off-by: Ingo Molnar <mingo@elte.hu>
2008-06-02 12:14:58 +02:00
..
2008-05-08 15:43:51 +02:00
2008-04-25 19:54:07 +02:00
2008-04-17 17:41:19 +02:00
2008-04-26 17:35:47 +02:00
2008-04-26 17:35:47 +02:00
2008-04-29 08:06:29 -07:00
2008-04-29 08:06:29 -07:00
2008-04-19 19:10:28 -07:00
2008-01-30 13:31:31 +01:00
2008-04-29 13:45:24 +02:00
2008-02-19 16:18:28 +01:00
2008-04-19 19:19:54 +02:00
2008-01-30 13:31:19 +01:00
2008-04-19 19:19:54 +02:00
2008-04-24 23:57:33 +02:00
2008-04-17 17:41:13 +02:00
2008-04-30 23:15:34 +02:00
2008-04-17 17:41:36 +02:00
2008-04-19 19:19:58 +02:00
2008-04-17 17:40:49 +02:00
2008-04-30 23:15:34 +02:00
2008-04-17 17:41:37 +02:00
2008-04-30 23:15:34 +02:00
2008-05-10 19:31:45 +02:00
2008-04-26 17:35:47 +02:00
2008-04-26 17:35:48 +02:00
2008-03-26 22:23:40 +01:00
2008-01-30 13:33:10 +01:00
2008-04-17 17:40:56 +02:00
2008-04-29 08:06:02 -07:00
2008-04-19 19:19:54 +02:00
2008-04-27 12:00:28 +03:00
2008-05-07 12:42:03 +02:00
2008-04-28 08:58:35 -07:00
2008-05-04 20:04:45 +02:00
2008-04-19 19:10:28 -07:00
2008-01-30 13:33:19 +01:00
2008-04-19 19:19:56 +02:00
2008-04-19 19:19:57 +02:00
2008-04-19 19:19:56 +02:00
2008-04-19 19:19:55 +02:00
2008-04-30 08:29:37 -07:00
2008-04-30 08:29:37 -07:00
2008-05-13 19:36:12 +02:00
2008-04-17 17:40:55 +02:00
2008-04-17 17:40:55 +02:00
2008-04-26 17:35:47 +02:00
2008-04-29 08:06:03 -07:00
2008-02-08 09:22:29 -08:00
2008-04-17 17:40:56 +02:00
2008-01-30 13:31:52 +01:00
2008-04-17 17:41:37 +02:00
2008-04-19 19:19:55 +02:00
2008-04-19 19:19:55 +02:00
2008-04-24 23:57:31 +02:00
2008-04-28 13:49:35 -07:00
2008-04-24 23:15:44 +02:00