Andrea Righi 27ac792ca0
PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures ...
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
boundary. For example:
u64 val = PAGE_ALIGN(size);
always returns a value < 4GB even if size is greater than 4GB.
The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
example):
#define PAGE_SHIFT 12
#define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK (~(PAGE_SIZE-1))
...
#define PAGE_ALIGN(addr) (((addr)+PAGE_SIZE-1)&PAGE_MASK)
The "~" is performed on a 32-bit value, so everything in "and" with
PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
Using the ALIGN() macro seems to be the right way, because it uses
typeof(addr) for the mask.
Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
include/linux/mm.h.
See also lkml discussion: http://lkml.org/lkml/2008/6/11/237
[akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
[akpm@linux-foundation.org: fix v850]
[akpm@linux-foundation.org: fix powerpc]
[akpm@linux-foundation.org: fix arm]
[akpm@linux-foundation.org: fix mips]
[akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
[akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
[akpm@linux-foundation.org: fix powerpc]
Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-24 10:47:21 -07:00
2008-07-18 12:51:21 +02:00
2008-07-21 21:35:38 +02:00
2008-07-18 12:51:21 +02:00
2008-07-20 09:25:52 +02:00
2008-07-08 10:38:54 +02:00
2008-03-27 16:08:45 +01:00
2008-07-18 12:51:21 +02:00
2008-07-15 21:55:59 +02:00
2008-07-18 14:35:14 +02:00
2008-07-10 18:55:40 +02:00
2008-07-22 10:43:44 +02:00
2008-04-17 17:41:21 +02:00
2008-02-08 09:22:29 -08:00
2008-07-08 10:38:47 +02:00
2008-01-30 13:34:07 +01:00
2008-05-23 20:33:28 +02:00
2008-07-11 18:01:18 +02:00
2008-06-27 10:12:21 +02:00
2008-07-21 21:35:38 +02:00
2008-04-17 17:41:33 +02:00
2008-07-20 09:25:52 +02:00
2008-07-09 09:14:12 +02:00
2008-04-17 17:41:21 +02:00
2008-07-08 12:24:13 +02:00
2008-06-05 15:10:02 +02:00
2008-07-18 14:32:38 +02:00
2008-04-19 19:19:54 +02:00
2008-07-08 13:16:14 +02:00
2008-04-17 17:41:22 +02:00
2008-02-04 16:48:04 +01:00
2008-04-17 17:41:22 +02:00
2008-04-17 17:41:31 +02:00
2008-07-16 12:15:17 -07:00
2008-04-17 17:41:22 +02:00
2008-04-17 17:41:22 +02:00
2008-04-17 17:41:22 +02:00
2008-07-08 13:10:58 +02:00
2008-04-17 17:41:22 +02:00
2008-02-01 17:49:43 +01:00
2008-07-18 12:51:21 +02:00
2008-05-25 08:58:35 +02:00
2008-07-09 09:13:59 +02:00
2008-07-08 13:10:28 +02:00
2008-07-14 11:37:46 +02:00
2008-05-01 08:03:58 -07:00
2008-07-18 14:39:37 -07:00
2008-04-17 17:41:22 +02:00
2008-07-08 10:38:47 +02:00
2008-01-30 13:32:03 +01:00
2008-07-15 15:30:29 +02:00
2008-07-18 14:10:27 +02:00
2008-04-17 17:41:23 +02:00
2008-06-05 15:10:02 +02:00
2008-07-08 13:15:58 +02:00
2008-01-30 13:32:51 +01:00
2008-07-18 16:17:52 -07:00
2008-07-14 09:24:17 +02:00
2008-06-20 15:09:56 +02:00
2008-04-17 17:41:30 +02:00
2008-07-18 13:14:08 +02:00
2008-04-30 08:29:52 -07:00
2008-07-11 11:00:54 +02:00
2008-07-13 11:43:48 +02:00
2008-07-13 11:43:48 +02:00
2008-06-19 14:19:03 +02:00
2008-01-30 13:33:35 +01:00
2008-05-25 07:11:49 +02:00
2008-07-08 10:38:19 +02:00
2008-07-09 07:43:25 +02:00
2008-07-24 10:47:17 -07:00
2008-07-15 21:55:59 +02:00
2008-04-17 17:41:23 +02:00
2008-06-04 13:11:46 +02:00
2008-01-30 13:33:14 +01:00
2008-05-24 16:44:26 +02:00
2008-01-30 13:30:28 +01:00
2008-04-17 17:41:23 +02:00
2008-04-18 00:46:35 +02:00
2008-01-30 13:30:28 +01:00
2008-07-24 10:47:15 -07:00
2008-07-24 10:47:15 -07:00
2008-07-08 13:16:04 +02:00
2008-07-08 13:16:12 +02:00
2008-04-17 17:41:23 +02:00
2008-07-11 11:00:54 +02:00
2008-04-17 17:41:24 +02:00
2008-07-16 00:29:07 +02:00
2008-07-15 21:55:59 +02:00
2008-05-12 21:28:05 +02:00
2008-07-14 16:11:52 +02:00
2008-01-30 13:30:16 +01:00
2008-04-17 17:41:33 +02:00
2008-05-24 11:22:12 +02:00
2008-04-17 17:41:24 +02:00
2008-04-17 20:05:37 +02:00
2008-04-17 17:41:24 +02:00
2008-07-21 11:03:32 +02:00
2008-07-06 11:05:18 +03:00
2008-07-20 12:42:35 +03:00
2008-07-20 12:40:48 +03:00
2008-04-17 17:41:24 +02:00
2008-04-17 17:41:24 +02:00
2008-04-17 17:40:51 +02:00
2008-04-17 17:41:24 +02:00
2008-01-30 13:31:55 +01:00
2008-04-17 17:41:24 +02:00
2008-04-17 17:41:25 +02:00
2008-01-30 13:30:56 +01:00
2008-06-10 12:32:53 +02:00
2008-07-08 13:10:31 +02:00
2008-07-08 13:10:31 +02:00
2008-07-08 13:10:31 +02:00
2008-04-17 17:41:25 +02:00
2008-04-17 17:41:25 +02:00
2008-06-10 11:34:42 +02:00
2008-04-17 17:41:25 +02:00
2008-01-30 13:31:43 +01:00
2008-07-08 12:23:29 +02:00
2008-07-08 12:24:13 +02:00
2008-04-17 17:41:25 +02:00
2008-06-10 15:52:07 +02:00
2008-07-08 13:10:24 +02:00
2008-04-17 17:41:25 +02:00
2008-04-17 17:41:25 +02:00
2008-04-17 17:41:25 +02:00
2008-07-08 12:51:42 +02:00
2008-04-17 17:40:58 +02:00
2008-07-08 13:10:33 +02:00
2008-07-08 12:50:14 +02:00
2008-07-13 08:19:45 +02:00
2008-04-29 08:06:07 -07:00
2008-07-08 13:16:22 +02:00
2008-07-09 07:43:23 +02:00
2008-07-24 10:47:21 -07:00
2008-04-17 17:41:26 +02:00
2008-07-22 10:43:44 +02:00
2008-04-17 17:41:26 +02:00
2008-06-12 10:14:27 +02:00
2008-06-30 12:22:01 +02:00
2008-04-19 19:19:55 +02:00
2008-06-10 10:59:52 -07:00
2008-07-08 09:13:08 +02:00
2008-07-08 11:31:25 +02:00
2008-07-16 10:58:13 +02:00
2008-07-08 13:11:01 +02:00
2008-07-22 10:43:45 +02:00
2008-07-22 10:43:44 +02:00
2008-04-17 17:41:26 +02:00
2008-07-22 10:43:44 +02:00
2008-07-22 10:43:45 +02:00
2008-04-17 17:41:26 +02:00
2008-04-17 17:41:26 +02:00
2008-04-26 17:35:46 +02:00
2008-06-02 12:48:23 +02:00
2008-07-23 18:37:44 -07:00
2008-07-08 11:49:49 +02:00
2008-07-16 12:15:17 -07:00
2008-06-02 12:48:23 +02:00
2008-06-24 21:02:31 +03:00
2008-06-24 21:02:31 +03:00
2008-05-25 08:58:30 +02:00
2008-07-08 13:11:08 +02:00
2008-05-25 07:09:47 +02:00
2008-04-26 17:35:47 +02:00
2008-01-30 13:30:34 +01:00
2008-04-17 17:41:27 +02:00
2008-04-19 19:19:57 +02:00
2008-06-02 12:45:28 +02:00
2008-06-18 12:27:03 +02:00
2008-07-17 11:29:24 -07:00
2008-04-17 10:42:34 -04:00
Merge branches 'x86/urgent', 'x86/amd-iommu', 'x86/apic', 'x86/cleanups', 'x86/core', 'x86/cpu', 'x86/fixmap', 'x86/gart', 'x86/kprobes', 'x86/memtest', 'x86/modules', 'x86/nmi', 'x86/pat', 'x86/reboot', 'x86/setup', 'x86/step', 'x86/unify-pci', 'x86/uv', 'x86/xen' and 'xen-64bit' into x86/for-linus
2008-07-21 16:37:17 +02:00
2008-04-17 17:41:27 +02:00
2008-04-17 17:41:27 +02:00
2008-07-18 17:59:13 +02:00
2008-07-16 10:55:07 +02:00
2008-01-31 19:27:19 -08:00
2008-04-17 17:41:33 +02:00
2008-07-16 11:15:52 +02:00
2008-07-16 11:15:53 +02:00
2008-07-08 15:49:08 +02:00
2008-01-30 13:33:07 +01:00
2008-05-26 13:36:53 -07:00
2008-04-17 17:41:27 +02:00
2008-06-18 12:27:03 +02:00
2008-04-17 17:41:27 +02:00
2008-07-11 11:00:55 +02:00
2008-04-17 17:41:30 +02:00
2008-01-30 13:31:08 +01:00
2008-07-11 19:51:47 +02:00
2008-04-17 17:41:28 +02:00
2008-02-07 08:42:16 -08:00
2008-07-23 19:36:53 -07:00
2008-07-09 07:43:27 +02:00
2008-07-09 07:43:28 +02:00
2008-02-06 10:41:02 -08:00
2008-05-23 18:16:15 +02:00
2008-07-13 19:11:58 +02:00
2008-04-17 17:41:37 +02:00
2008-07-18 18:51:57 +02:00
2008-07-09 07:43:27 +02:00
2008-05-02 16:18:42 -07:00
2008-07-09 09:14:29 +02:00
2008-07-09 15:51:03 +02:00
2008-07-09 09:14:29 +02:00
2008-04-29 08:06:27 -07:00
2008-04-17 17:41:28 +02:00
2008-06-19 14:25:11 +02:00
2008-04-26 17:35:46 +02:00
2008-04-17 17:41:28 +02:00
2008-04-17 17:41:28 +02:00
2008-04-17 17:41:28 +02:00
2008-02-07 08:42:30 -08:00
2008-07-16 11:08:27 +02:00
2008-04-17 17:41:28 +02:00
2008-06-02 12:48:23 +02:00
2008-07-09 07:43:28 +02:00
2008-04-17 17:41:28 +02:00
2008-04-17 17:41:29 +02:00
2008-05-23 20:31:39 +02:00
2008-06-18 12:27:03 +02:00
2008-06-18 12:27:03 +02:00
27ac792ca0