sugar/linux
1
0
Fork 0
Code Activity
Files
ea84b580b95521644429cc6748b6c2bf27c8b0f3
linux/fs
History
Kees Cook ea84b580b9 pstore: Convert buf_lock to semaphore 
Instead of running with interrupts disabled, use a semaphore. This should
make it easier for backends that may need to sleep (e.g. EFI) when
performing a write:

|BUG: sleeping function called from invalid context at kernel/sched/completion.c:99
|in_atomic(): 1, irqs_disabled(): 1, pid: 2236, name: sig-xstate-bum
|Preemption disabled at:
|[<ffffffff99d60512>] pstore_dump+0x72/0x330
|CPU: 26 PID: 2236 Comm: sig-xstate-bum Tainted: G      D           4.20.0-rc3 #45
|Call Trace:
| dump_stack+0x4f/0x6a
| ___might_sleep.cold.91+0xd3/0xe4
| __might_sleep+0x50/0x90
| wait_for_completion+0x32/0x130
| virt_efi_query_variable_info+0x14e/0x160
| efi_query_variable_store+0x51/0x1a0
| efivar_entry_set_safe+0xa3/0x1b0
| efi_pstore_write+0x109/0x140
| pstore_dump+0x11c/0x330
| kmsg_dump+0xa4/0xd0
| oops_exit+0x22/0x30
...

Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Fixes: 21b3ddd39f ("efi: Don't use spinlocks for efi vars")
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-12-03 17:11:02 -08:00
..
9p
Merge branch 'work.afs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2018-11-01 19:58:52 -07:00
adfs
adfs: use timespec64 for time conversion
2018-08-22 10:52:51 -07:00
affs
affs: fix potential memory leak when parsing option 'prefix'
2018-05-28 12:36:41 +02:00
afs
afs: Probe multiple fileservers simultaneously
2018-10-24 00:41:09 +01:00
autofs
Merge branch 'akpm' (patches from Andrew)
2018-08-22 12:34:08 -07:00
befs
fix a series of Documentation/ broken file name references
2018-06-15 18:10:01 -03:00
bfs
bfs: add sanity check at bfs_fill_super()
2018-11-03 10:09:38 -07:00
btrfs
Merge tag 'for-4.20-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux
2018-11-11 16:54:38 -06:00
cachefiles
cachefiles: fix the race between cachefiles_bury_object() and rmdir(2)
2018-10-18 11:32:21 +02:00
ceph
libceph: assume argonaut on the server side
2018-11-08 17:51:11 +01:00
cifs
cifs: fix signed/unsigned mismatch on aio_read patch
2018-11-02 14:09:42 -05:00
coda
vfs: change inode times to use struct timespec64
2018-06-05 16:57:31 -07:00
configfs
configfs: fix registered group removal
2018-07-17 06:14:07 -07:00
cramfs
Merge tag 'cramfs_fixes' of git://git.linaro.org/people/nicolas.pitre/linux
2018-10-30 12:46:25 -07:00
crypto
crypto: speck - remove Speck
2018-09-04 11:35:03 +08:00
debugfs
Revert "debugfs: inode: debugfs_create_dir uses mode permission from parent"
2018-06-12 20:52:16 -07:00
devpts
devpts: Convert to new IDA API
2018-08-21 23:54:17 -04:00
dlm
iov_iter: Separate type from direction and use accessor functions
2018-10-24 00:41:07 +01:00
ecryptfs
ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()
2018-10-09 23:33:17 -04:00
efivarfs
efivars: Call guid_parse() against guid_t type of variable
2018-07-22 14:13:44 +02:00
efs
…
exofs
fs/exofs: only use true/false for asignment of bool type variable
2018-10-18 02:04:59 -04:00
exportfs
ovl: do not try to reconnect a disconnected origin dentry
2018-04-12 12:04:49 +02:00
ext2
Merge tag 'filesystems_for_v4.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
2018-10-29 10:23:36 -07:00
ext4
Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4
2018-11-11 16:53:02 -06:00
f2fs
Merge branch 'xarray' of git://git.infradead.org/users/willy/linux-dax
2018-10-28 11:35:40 -07:00
fat
fat: truncate inode timestamp updates in setattr
2018-10-31 08:54:14 -07:00
freevxfs
freevxfs_lookup(): use d_splice_alias()
2018-05-22 14:27:51 -04:00
fscache
fscache: Fix out of bound read in long cookie keys
2018-10-18 11:32:21 +02:00
fuse
Merge branch 'work.afs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2018-11-01 19:58:52 -07:00
gfs2
Merge branch 'xarray' of git://git.infradead.org/users/willy/linux-dax
2018-10-28 11:35:40 -07:00
hfs
fs/hfs/extent.c: fix array out of bounds read of array extent
2018-10-31 08:54:13 -07:00
hfsplus
hfsplus: update timestamps on truncate()
2018-10-31 08:54:13 -07:00
hostfs
vfs: discard ATTR_ATTR_FLAG
2018-08-17 16:20:28 -07:00
hpfs
hpfs: remove unnecessary checks on the value of r when assigning error code
2018-08-25 12:42:33 -07:00
hugetlbfs
mm: zero out the vma in vma_init()
2018-08-22 10:52:44 -07:00
isofs
Update email address
2018-09-29 22:47:48 -04:00
jbd2
jbd2: fix use after free in jbd2_log_do_checkpoint()
2018-10-05 18:44:40 -04:00
jffs2
Merge branch 'siginfo-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2018-10-24 11:22:39 +01:00
jfs
jfs: remove redundant dquot_initialize() in jfs_evict_inode()
2018-09-20 09:28:49 -05:00
kernfs
mm: zero-seek shrinkers
2018-10-26 16:26:33 -07:00
lockd
lockd: fix access beyond unterminated strings in prints
2018-10-29 16:58:04 -04:00
minix
minix_lookup: use d_splice_alias()
2018-05-22 14:27:52 -04:00
nfs
Merge tag 'nfs-for-4.20-2' of git://git.linux-nfs.org/projects/trondmy/linux-nfs
2018-11-04 08:20:09 -08:00
nfs_common
…
nfsd
Merge tag 'xfs-4.20-merge-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2018-11-02 09:33:08 -07:00
nilfs2
nilfs2: Convert to XArray
2018-10-21 10:46:42 -04:00
nls
…
notify
fsnotify: Fix busy inodes during unmount
2018-10-25 15:49:19 +02:00
ntfs
ntfs: don't open-code ERR_CAST
2018-10-12 22:46:50 -04:00
ocfs2
ocfs2: fix clusters leak in ocfs2_defrag_extent()
2018-11-03 10:09:37 -07:00
omfs
omfs_lookup(): report IO errors, use d_splice_alias()
2018-05-22 14:27:58 -04:00
openpromfs
openpromfs: switch to d_splice_alias()
2018-05-22 14:27:57 -04:00
orangefs
Merge branch 'work.afs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2018-11-01 19:58:52 -07:00
overlayfs
Merge tag 'xfs-4.20-merge-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2018-11-02 09:33:08 -07:00
proc
Merge tag 'stackleak-v4.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2018-11-01 11:46:27 -07:00
pstore
pstore: Convert buf_lock to semaphore
2018-12-03 17:11:02 -08:00
qnx4
qnx4_lookup: use d_splice_alias()
2018-05-22 14:27:52 -04:00
qnx6
qnx6_lookup: switch to d_splice_alias()
2018-05-22 14:27:54 -04:00
quota
fs/quota: Fix spectre gadget in do_quotactl
2018-08-22 18:17:48 +02:00
ramfs
…
reiserfs
reiserfs: remove workaround code for GCC 3.x
2018-10-31 08:54:14 -07:00
romfs
romfs_lookup: switch to d_splice_alias()
2018-05-22 14:27:55 -04:00
squashfs
Squashfs: Compute expected length from inode size rather than block length
2018-08-02 09:34:02 -07:00
sysfs
Merge tag 'driver-core-4.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
2018-08-18 11:44:53 -07:00
sysv
fs/sysv/inode.c: use ktime_get_real_seconds() for superblock stamp
2018-08-22 10:52:51 -07:00
tracefs
tracefs: Annotate tracefs_ops with __ro_after_init
2018-07-31 11:32:44 -04:00
ubifs
ubifs: Remove unneeded semicolon
2018-10-23 13:49:02 +02:00
udf
udf: Drop pack pragma from udf_sb.h
2018-09-07 10:32:23 +02:00
ufs
fs/ufs: use ktime_get_real_seconds for sb and cg timestamps
2018-08-17 16:20:27 -07:00
xfs
xfs: fix overflow in xfs_attr3_leaf_verify
2018-11-06 07:50:50 -08:00
aio.c
y2038: globally rename compat_time to old_time32
2018-08-27 14:48:48 +02:00
anon_inodes.c
anon_inode_getfile(): switch to alloc_file_pseudo()
2018-07-12 10:04:27 -04:00
attr.c
fs: Fix attr.c kernel-doc
2018-07-03 16:44:45 -04:00
bad_inode.c
get rid of 'opened' argument of ->atomic_open() - part 3
2018-07-12 10:04:20 -04:00
binfmt_aout.c
exec: introduce finalize_exec() before start_thread()
2018-04-11 10:28:37 -07:00
binfmt_elf_fdpic.c
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
binfmt_elf.c
signal: Distinguish between kernel_siginfo and siginfo
2018-10-03 16:47:43 +02:00
binfmt_em86.c
…
binfmt_flat.c
exec: introduce finalize_exec() before start_thread()
2018-04-11 10:28:37 -07:00
binfmt_misc.c
turn filp_clone_open() into inline wrapper for dentry_open()
2018-07-10 23:29:03 -04:00
binfmt_script.c
…
block_dev.c
iov_iter: Use accessor function
2018-10-24 00:40:44 +01:00
buffer.c
Merge tag 'for-linus-20181102' of git://git.kernel.dk/linux-block
2018-11-02 11:25:48 -07:00
char_dev.c
…
compat_binfmt_elf.c
y2038: globally rename compat_time to old_time32
2018-08-27 14:48:48 +02:00
compat_ioctl.c
Merge tag 'media/v4.20-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media
2018-10-29 14:29:58 -07:00
compat.c
ncpfs: remove compat functionality
2018-06-05 19:23:26 +02:00
coredump.c
signal: Distinguish between kernel_siginfo and siginfo
2018-10-03 16:47:43 +02:00
d_path.c
…
dax.c
dax: Convert page fault handlers to XArray
2018-10-21 10:46:44 -04:00
dcache.c
mm: remove include/linux/bootmem.h
2018-10-31 08:54:16 -07:00
dcookies.c
fs: add do_lookup_dcookie() helper; remove in-kernel call to syscall
2018-04-02 20:15:39 +02:00
direct-io.c
iov_iter: Use accessor function
2018-10-24 00:40:44 +01:00
drop_caches.c
…
eventfd.c
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
eventpoll.c
fs/eventpoll.c: simplify ep_is_linked() callers
2018-08-22 10:52:49 -07:00
exec.c
vfs: require i_size <= SIZE_MAX in kernel_read_file()
2018-10-10 12:56:14 -04:00
fcntl.c
signal: Distinguish between kernel_siginfo and siginfo
2018-10-03 16:47:43 +02:00
fhandle.c
…
file_table.c
Merge tag 'ovl-update-4.19' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs
2018-08-21 18:19:09 -07:00
file.c
fs: add ksys_close() wrapper; remove in-kernel calls to sys_close()
2018-04-02 20:16:00 +02:00
filesystems.c
proc: introduce proc_create_single{,_data}
2018-05-16 07:23:35 +02:00
fs_pin.c
…
fs_struct.c
…
fs-writeback.c
fs: Convert writeback to XArray
2018-10-21 10:46:42 -04:00
inode.c
mm: remove include/linux/bootmem.h
2018-10-31 08:54:16 -07:00
internal.h
Merge tag 'ovl-update-4.19' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs
2018-08-21 18:19:09 -07:00
ioctl.c
Merge tag 'xfs-4.20-merge-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2018-11-02 09:33:08 -07:00
iomap.c
Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2018-11-01 20:19:49 -07:00
Kconfig
autofs: remove left-over autofs4 stubs
2018-06-11 08:22:34 -07:00
Kconfig.binfmt
kconfig: move the "Executable file formats" menu to fs/Kconfig.binfmt
2018-08-02 08:06:55 +09:00
libfs.c
…
locks.c
Merge tag 'ovl-update-4.19' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs
2018-08-21 18:19:09 -07:00
Makefile
autofs: remove left-over autofs4 stubs
2018-06-11 08:22:34 -07:00
mbcache.c
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
mount.h
…
mpage.c
mpage: mpage_readpages() should submit IO as read-ahead
2018-08-17 16:20:29 -07:00
namei.c
namei: allow restricted O_CREAT of FIFOs and regular files
2018-08-23 18:48:43 -07:00
namespace.c
mount: Prevent MNT_DETACH from disconnecting locked mounts
2018-11-08 01:05:32 -06:00
no-block.c
…
nsfs.c
…
open.c
Merge tag 'ovl-update-4.19' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs
2018-08-21 18:19:09 -07:00
pipe.c
Merge branch 'work.open3' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2018-08-13 19:58:36 -07:00
pnode.c
…
pnode.h
…
posix_acl.c
…
proc_namespace.c
…
read_write.c
Merge tag 'xfs-4.20-merge-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2018-11-02 09:33:08 -07:00
readdir.c
fs: add ksys_getdents64() helper; remove in-kernel calls to sys_getdents64()
2018-04-02 20:16:02 +02:00
select.c
y2038: globally rename compat_time to old_time32
2018-08-27 14:48:48 +02:00
seq_file.c
fs/seq_file.c: simplify seq_file iteration code and interface
2018-08-17 16:20:28 -07:00
signalfd.c
signal: Distinguish between kernel_siginfo and siginfo
2018-10-03 16:47:43 +02:00
splice.c
iov_iter: Separate type from direction and use accessor functions
2018-10-24 00:41:07 +01:00
stack.c
…
stat.c
y2038: Remove newstat family from default syscall set
2018-08-29 15:42:20 +02:00
statfs.c
kernel: add kcompat_sys_{f,}statfs64()
2018-07-12 14:49:48 +01:00
super.c
fsnotify: add super block object type
2018-09-03 15:14:01 +02:00
sync.c
Merge tag 'xfs-4.17-merge-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2018-04-04 12:44:02 -07:00
timerfd.c
y2038: globally rename compat_time to old_time32
2018-08-27 14:48:48 +02:00
userfaultfd.c
userfaultfd: disable irqs when taking the waitqueue lock
2018-10-26 16:25:18 -07:00
utimes.c
y2038: utimes: Rework #ifdef guards for compat syscalls
2018-08-29 15:42:23 +02:00
xattr.c
sysfs: Do not return POSIX ACL xattrs via listxattr
2018-09-18 07:30:48 -04:00