David Miller
f629307c85
tty: termios locking functions break with new termios type
...
I ran into a few problems.
n_tty_ioctl() for instance:
drivers/char/tty_ioctl.c:799: error: $,1rxstruct termios$,1ry has no
member named $,1rxc_ispeed$,1ry
This is calling the copy interface that is supposed to be using
a termios2 when the new interfaces are defined, however:
case TIOCGLCKTRMIOS:
if (kernel_termios_to_user_termios((struct termios __user *)arg, real_tty->termios_locked))
return -EFAULT;
return 0;
This is going to write over the end of the userspace
structure by a few bytes, and wasn't caught by you yet
because the i386 implementation is simply copy_to_user()
which does zero type checking.
Signed-off-by: Alan Cox <alan@redhat.com >
Cc: "David S. Miller" <davem@davemloft.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-09-11 17:21:20 -07:00
..
2007-08-25 18:14:00 +10:00
2007-08-25 08:01:06 -07:00
2007-07-21 18:37:13 -07:00
2007-07-31 15:39:44 -07:00
2007-08-22 19:52:46 -07:00
2007-02-20 17:10:14 -08:00
2007-08-11 15:47:40 -07:00
2007-07-19 10:04:50 -07:00
2007-08-22 19:52:44 -07:00
2007-08-16 20:28:43 +00:00
2007-07-19 10:04:50 -07:00
2007-07-17 10:23:02 -07:00
2007-07-10 22:03:26 +10:00
2007-07-16 09:05:46 -07:00
2007-05-08 11:15:04 -07:00
2007-07-17 16:23:19 -04:00
2007-03-08 01:10:30 +00:00
2007-05-08 11:15:07 -07:00
2007-05-08 11:15:07 -07:00
2007-05-08 11:15:09 -07:00
2007-05-08 11:15:07 -07:00
2007-05-08 11:15:13 -07:00
2007-07-19 10:04:50 -07:00
2007-02-12 09:48:45 -08:00
2007-07-16 09:05:51 -07:00
2007-07-16 09:05:44 -07:00
2007-05-21 09:18:19 -07:00
2007-08-31 20:14:22 -07:00
2007-07-17 10:23:02 -07:00
2007-07-22 21:30:59 +10:00
2007-08-11 15:47:42 -07:00
2007-07-22 21:30:59 +10:00
2007-05-07 20:31:14 +10:00
2007-07-18 08:47:44 -07:00
2007-07-22 21:30:59 +10:00
2007-04-27 15:51:56 +10:00
2007-05-08 11:15:08 -07:00
2007-05-08 11:15:07 -07:00
2007-07-17 10:23:10 -07:00
2007-07-17 10:23:10 -07:00
2007-07-26 11:35:19 -07:00
2007-08-22 19:52:45 -07:00
2007-08-27 02:16:59 +01:00
2007-02-20 17:11:55 +00:00
2007-05-08 11:15:08 -07:00
2007-07-31 20:43:52 -07:00
2007-07-19 10:04:43 -07:00
2007-07-19 10:04:43 -07:00
2007-07-10 14:48:43 -07:00
2007-07-16 09:05:42 -07:00
2007-07-29 17:09:29 -07:00
2007-07-17 10:23:10 -07:00
2007-07-29 17:09:29 -07:00
2007-07-16 09:05:52 -07:00
2007-07-16 09:05:52 -07:00
2007-07-16 09:05:43 -07:00
2007-07-16 09:05:44 -07:00
2007-07-16 09:05:47 -07:00
2007-07-16 09:05:47 -07:00
2007-02-14 08:09:54 -08:00
2007-05-08 11:15:07 -07:00
2007-07-21 17:49:16 -07:00
2007-02-14 08:09:54 -08:00
2007-07-19 14:21:04 -07:00
2007-07-17 10:23:10 -07:00
2007-05-11 08:29:36 -07:00
2007-07-19 10:04:50 -07:00
2007-07-21 18:37:08 -07:00
2007-07-16 09:05:46 -07:00
2007-02-14 08:09:54 -08:00
2007-07-20 08:24:49 -07:00
2007-05-10 13:23:05 -07:00
2007-08-23 15:20:26 -04:00
2007-07-17 10:23:10 -07:00
2007-07-19 10:04:43 -07:00
2007-07-10 17:51:13 -07:00
2007-08-22 19:52:46 -07:00
2007-07-19 10:04:50 -07:00
2007-07-19 10:04:50 -07:00
2007-05-08 11:15:07 -07:00
2007-05-08 11:15:05 -07:00
2007-02-14 08:09:54 -08:00
2007-02-14 08:09:54 -08:00
2007-07-16 09:05:47 -07:00
2007-08-23 21:39:41 -07:00
2007-09-11 17:21:20 -07:00
2007-05-08 11:15:33 -07:00
2007-07-19 10:04:43 -07:00
2007-07-20 08:24:49 -07:00
2007-07-12 17:41:15 +01:00
2007-05-08 11:15:13 -07:00
2007-07-17 10:23:13 -07:00