Wang Hai
6b70fc94af
net-sysfs: Fix memory leak in netdev_register_kobject
When registering struct net_device, it will call
register_netdevice ->
netdev_register_kobject ->
device_initialize(dev);
dev_set_name(dev, "%s", ndev->name)
device_add(dev)
register_queue_kobjects(ndev)
In netdev_register_kobject(), if device_add(dev) or
register_queue_kobjects(ndev) failed. Register_netdevice()
will return error, causing netdev_freemem(ndev) to be
called to free net_device, however put_device(&dev->dev)->..->
kobject_cleanup() won't be called, resulting in a memory leak.
syzkaller report this:
BUG: memory leak
unreferenced object 0xffff8881f4fad168 (size 8):
comm "syz-executor.0", pid 3575, jiffies 4294778002 (age 20.134s)
hex dump (first 8 bytes):
77 70 61 6e 30 00 ff ff wpan0...
backtrace:
[<000000006d2d91d7>] kstrdup_const+0x3d/0x50 mm/util.c:73
[<00000000ba9ff953>] kvasprintf_const+0x112/0x170 lib/kasprintf.c:48
[<000000005555ec09>] kobject_set_name_vargs+0x55/0x130 lib/kobject.c:281
[<0000000098d28ec3>] dev_set_name+0xbb/0xf0 drivers/base/core.c:1915
[<00000000b7553017>] netdev_register_kobject+0xc0/0x410 net/core/net-sysfs.c:1727
[<00000000c826a797>] register_netdevice+0xa51/0xeb0 net/core/dev.c:8711
[<00000000857bfcfd>] cfg802154_update_iface_num.isra.2+0x13/0x90 [ieee802154]
[<000000003126e453>] ieee802154_llsec_fill_key_id+0x1d5/0x570 [ieee802154]
[<00000000e4b3df51>] 0xffffffffc1500e0e
[<00000000b4319776>] platform_drv_probe+0xc6/0x180 drivers/base/platform.c:614
[<0000000037669347>] really_probe+0x491/0x7c0 drivers/base/dd.c:509
[<000000008fed8862>] driver_probe_device+0xdc/0x240 drivers/base/dd.c:671
[<00000000baf52041>] device_driver_attach+0xf2/0x130 drivers/base/dd.c:945
[<00000000c7cc8dec>] __driver_attach+0x10e/0x210 drivers/base/dd.c:1022
[<0000000057a757c2>] bus_for_each_dev+0x154/0x1e0 drivers/base/bus.c:304
[<000000005f5ae04b>] bus_add_driver+0x427/0x5e0 drivers/base/bus.c:645
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 1fa5ae857b ("driver core: get rid of struct device's bus_id string array")
Signed-off-by: Wang Hai <wanghai26@huawei.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-03-21 13:38:27 -07:00
..
2019-01-22 09:51:19 +01:00
2018-12-25 17:07:49 +09:00
2019-02-24 17:40:46 -08:00
2019-03-15 11:25:48 -07:00
2019-03-07 10:14:50 -08:00
2019-01-23 11:18:00 -08:00
2019-02-15 12:38:38 -08:00
2019-02-26 10:08:26 +01:00
2019-03-08 21:17:07 +01:00
2019-02-23 13:34:40 -08:00
2019-03-18 16:21:54 +01:00
2019-02-17 11:01:17 -08:00
2019-01-22 11:33:46 +01:00
2019-03-05 18:55:17 +01:00
2019-03-21 13:38:27 -07:00
2019-03-19 14:01:40 -07:00
2019-01-29 21:18:54 -08:00
2019-03-03 20:45:52 -08:00
2019-02-22 12:55:31 -08:00
2019-03-07 11:02:08 -08:00
2019-02-26 08:27:05 -08:00
2019-03-11 15:36:49 -07:00
2019-03-21 10:07:00 -07:00
2019-02-23 13:46:24 -08:00
2019-02-12 10:36:42 +01:00
2019-03-13 14:19:35 -07:00
2018-12-03 14:15:26 -08:00
2019-02-24 12:06:19 -08:00
2019-03-19 16:00:22 -07:00
2019-03-16 11:44:33 -07:00
2019-03-20 08:32:58 +01:00
2019-02-27 21:45:24 -08:00
2019-03-21 09:29:06 -07:00
2019-01-27 10:38:04 -08:00
2019-03-19 13:48:07 -07:00
2019-03-16 11:43:14 -07:00
2019-03-20 10:46:50 -07:00
2019-02-21 16:23:56 -08:00
2019-03-05 21:07:14 -08:00
2019-03-09 15:53:03 -08:00
2018-12-18 13:13:56 +01:00
2019-03-18 16:53:22 -07:00
2019-03-08 18:24:53 -08:00
2019-03-21 13:26:42 -07:00
2019-03-20 11:09:47 -07:00
2019-03-12 13:27:20 -07:00
2019-03-15 12:51:56 -07:00
2019-03-12 15:06:54 -07:00
2019-03-01 21:35:19 -08:00
2019-03-21 09:09:04 -07:00
2019-03-13 14:16:44 -07:00
2019-03-08 14:48:40 -08:00
2019-03-08 15:15:44 -08:00
2019-02-22 13:48:13 +01:00
2019-03-11 15:40:14 -07:00
2019-03-16 01:27:51 +01:00
2019-02-18 10:58:54 +01:00
2019-03-05 14:08:26 -08:00
2019-02-26 08:49:05 -08:00
2019-02-28 08:24:23 -07:00
2019-03-15 15:29:47 -07:00