sugar/linux
1
0
Fork 0
Code Activity
Files
fed474857efbed79cd390d0aee224231ca718f63
linux/fs
History
Miklos Szeredi fed474857e fsnotify: don't BUG in fsnotify_destroy_mark() 
Removing the parent of a watched file results in "kernel BUG at
fs/notify/mark.c:139".

To reproduce

  add "-w /tmp/audit/dir/watched_file" to audit.rules
  rm -rf /tmp/audit/dir

This is caused by fsnotify_destroy_mark() being called without an
extra reference taken by the caller.

Reported by Francesco Cosoleto here:

  https://bugzilla.novell.com/show_bug.cgi?id=689860

Fix by removing the BUG_ON and adding a comment about not accessing mark after
the iput.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
CC: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-01-14 18:01:42 -08:00
..
9p
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs
2012-01-10 15:09:01 -08:00
adfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
affs
affs: propagate umode_t
2012-01-03 22:55:04 -05:00
afs
switch ->create() to umode_t
2012-01-03 22:54:53 -05:00
autofs4
autofs4 - fix deal with autofs4_write races
2012-01-13 08:30:49 -08:00
befs
vfs: fix the stupidity with i_dentry in inode destructors
2012-01-03 22:52:40 -05:00
bfs
switch ->create() to umode_t
2012-01-03 22:54:53 -05:00
btrfs
mm: compaction: introduce sync-light migration for use by compaction
2012-01-12 20:13:09 -08:00
cachefiles
fs: move code out of buffer.c
2012-01-03 22:54:07 -05:00
ceph
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client
2012-01-13 10:29:21 -08:00
cifs
Merge branch 'for-linus2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2012-01-08 12:19:57 -08:00
coda
coda: switch coda_cnode_make() to sane API as well, clean coda_lookup()
2012-01-10 11:13:16 -05:00
configfs
configfs: convert to umode_t
2012-01-03 22:54:57 -05:00
cramfs
Merge branches 'vfsmount-guts', 'umode_t' and 'partitions' into Z
2012-01-06 23:15:54 -05:00
debugfs
Merge branch 'for-linus2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2012-01-08 12:19:57 -08:00
devpts
devpts: fix double-free on mount failure
2012-01-08 20:19:03 -05:00
dlm
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm
2012-01-10 14:55:55 -08:00
ecryptfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
efs
vfs: fix the stupidity with i_dentry in inode destructors
2012-01-03 22:52:40 -05:00
exofs
Merge branch 'for-linus' of git://git.open-osd.org/linux-open-osd
2012-01-09 12:51:01 -08:00
exportfs
…
ext2
Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
2012-01-09 12:51:21 -08:00
ext3
Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
2012-01-09 12:51:21 -08:00
ext4
Merge branch 'for_linus' into for_linus_merged
2012-01-10 11:54:07 -05:00
fat
Merge branch 'usb-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb
2012-01-09 12:09:47 -08:00
freevxfs
fs: propagate umode_t, misc bits
2012-01-03 22:55:10 -05:00
fscache
…
fuse
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse
2012-01-12 12:39:21 -08:00
gfs2
GFS2: Fix nlink setting on inode creation
2012-01-11 12:35:05 +00:00
hfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
hfsplus
hfsplus: creation of hidden dir on mount can fail
2012-01-10 17:48:52 -05:00
hostfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
hpfs
switch ->mknod() to umode_t
2012-01-03 22:54:54 -05:00
hppfs
vfs: for usbfs, etc. internal vfsmounts ->mnt_sb->s_root == ->mnt_root
2012-01-03 22:52:41 -05:00
hugetlbfs
mm: compaction: introduce sync-light migration for use by compaction
2012-01-12 20:13:09 -08:00
isofs
isofs: inode leak on mount failure
2012-01-09 10:48:11 -05:00
jbd
Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
2012-01-09 12:51:21 -08:00
jbd2
Merge branch 'for_linus' into for_linus_merged
2012-01-10 11:54:07 -05:00
jffs2
Merge tag 'for-linus-3.3' of git://git.infradead.org/mtd-2.6
2012-01-10 13:45:22 -08:00
jfs
Merge branch 'pm-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
2012-01-08 13:10:57 -08:00
lockd
module_param: make bool parameters really bool (drivers & misc)
2012-01-13 09:32:20 +10:30
logfs
Merge tag 'for-linus-3.3' of git://git.infradead.org/mtd-2.6
2012-01-10 13:45:22 -08:00
minix
Merge branch 'for-linus2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2012-01-08 12:19:57 -08:00
ncpfs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
nfs
Merge tag 'for-linus' of git://github.com/rustyrussell/linux
2012-01-14 12:32:16 -08:00
nfs_common
…
nfsd
Merge branch 'for-3.3' of git://linux-nfs.org/~bfields/linux
2012-01-14 12:26:41 -08:00
nilfs2
Merge branch 'pm-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
2012-01-08 13:10:57 -08:00
nls
NLS: raname "maxlen" to "maxout" in UTF conversion routines
2011-11-26 19:58:47 -08:00
notify
fsnotify: don't BUG in fsnotify_destroy_mark()
2012-01-14 18:01:42 -08:00
ntfs
module_param: avoid bool abuse, add bint for special cases.
2012-01-13 09:32:17 +10:30
ocfs2
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm
2012-01-10 14:55:55 -08:00
omfs
omfs: propagate umode_t
2012-01-03 22:55:01 -05:00
openpromfs
vfs: fix the stupidity with i_dentry in inode destructors
2012-01-03 22:52:40 -05:00
proc
c/r: procfs: add start_data, end_data, start_brk members to /proc/$pid/stat v4
2012-01-12 20:13:13 -08:00
pstore
pstore: gracefully handle NULL pstore_info functions
2011-11-18 13:49:00 -08:00
qnx4
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
2012-01-08 13:21:22 -08:00
quota
vfs: prefer ->dentry->d_sb to ->mnt->mnt_sb
2012-01-06 23:16:53 -05:00
ramfs
pohmelfs: propagate umode_t
2012-01-03 22:55:07 -05:00
reiserfs
reiserfs: don't lock root inode searching
2012-01-10 16:30:54 -08:00
romfs
Merge tag 'for-linus-3.3' of git://git.infradead.org/mtd-2.6
2012-01-10 13:45:22 -08:00
squashfs
Merge git://git.kernel.org/pub/scm/linux/kernel/git/pkl/squashfs-next
2012-01-13 10:34:57 -08:00
sysfs
sysfs: propagate umode_t
2012-01-03 22:55:03 -05:00
sysv
vfs: prefer ->dentry->d_sb to ->mnt->mnt_sb
2012-01-06 23:16:53 -05:00
ubifs
Merge branch 'linux-next' of git://git.infradead.org/ubifs-2.6
2012-01-13 10:31:33 -08:00
udf
Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
2012-01-09 12:51:21 -08:00
ufs
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
xfs
Merge branch 'for-linus' of git://oss.sgi.com/xfs/xfs
2012-01-09 12:50:15 -08:00
aio.c
Unused iocbs in a batch should not be accounted as active.
2012-01-13 20:39:44 -08:00
anon_inodes.c
…
attr.c
switch is_sxid() to umode_t
2012-01-03 22:55:11 -05:00
bad_inode.c
switch ->mknod() to umode_t
2012-01-03 22:54:54 -05:00
binfmt_aout.c
…
binfmt_elf_fdpic.c
…
binfmt_elf.c
fs: binfmt_elf: create Kconfig variable for PIE randomization
2012-01-10 16:30:51 -08:00
binfmt_em86.c
…
binfmt_flat.c
…
binfmt_misc.c
vfs: prefer ->dentry->d_sb to ->mnt->mnt_sb
2012-01-06 23:16:53 -05:00
binfmt_script.c
…
binfmt_som.c
…
bio-integrity.c
fs: add export.h to files using EXPORT_SYMBOL/THIS_MODULE macros
2011-10-31 19:30:31 -04:00
bio.c
bio: change some signed vars to unsigned
2011-11-16 09:21:50 +01:00
block_dev.c
vfs: cache request_queue in struct block_device
2012-01-12 20:13:12 -08:00
buffer.c
fs: move code out of buffer.c
2012-01-03 22:54:07 -05:00
char_dev.c
char_dev.c: fix up some whitespace errors
2011-12-13 11:18:17 -08:00
compat_binfmt_elf.c
…
compat_ioctl.c
vfs: fix up ENOIOCTLCMD error handling
2012-01-05 15:40:12 -08:00
compat.c
switch open and mkdir syscalls to umode_t
2012-01-03 22:55:19 -05:00
dcache.c
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client
2012-01-13 10:29:21 -08:00
dcookies.c
…
direct-io.c
dio: optimize cache misses in the submission path
2012-01-12 20:13:12 -08:00
drop_caches.c
…
eventfd.c
…
eventpoll.c
epoll: limit paths
2012-01-12 20:13:04 -08:00
exec.c
tracepoint: add tracepoints for debugging oom_score_adj
2012-01-10 16:30:44 -08:00
fcntl.c
…
fhandle.c
vfs: prefer ->dentry->d_sb to ->mnt->mnt_sb
2012-01-06 23:16:53 -05:00
fifo.c
…
file_table.c
vfs: prevent remount read-only if pending removes
2012-01-06 23:20:13 -05:00
file.c
…
filesystems.c
vfs: convert fs_supers to hlist
2012-01-03 22:52:39 -05:00
fs_struct.c
…
fs-writeback.c
Merge branch 'writeback-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/wfg/linux
2012-01-10 16:59:59 -08:00
generic_acl.c
…
inode.c
mm: account reaped page cache on inode cache pruning
2012-01-10 16:30:42 -08:00
internal.h
vfs: protect remounting superblock read-only
2012-01-06 23:20:12 -05:00
ioctl.c
vfs: fix up ENOIOCTLCMD error handling
2012-01-05 15:40:12 -08:00
ioprio.c
fs: add export.h to files using EXPORT_SYMBOL/THIS_MODULE macros
2011-10-31 19:30:31 -04:00
Kconfig
Merge branch 'for-linus' of git://git.open-osd.org/linux-open-osd
2012-01-09 12:51:01 -08:00
Kconfig.binfmt
fs: binfmt_elf: create Kconfig variable for PIE randomization
2012-01-10 16:30:51 -08:00
libfs.c
fs: move code out of buffer.c
2012-01-03 22:54:07 -05:00
locks.c
vfs: fix handling of lock allocation failure in lease-break case
2011-12-26 10:25:26 -08:00
Makefile
Merge branches 'vfsmount-guts', 'umode_t' and 'partitions' into Z
2012-01-06 23:15:54 -05:00
mbcache.c
…
mount.h
vfs: keep list of mounts for each superblock
2012-01-06 23:20:12 -05:00
mpage.c
…
namei.c
Merge branches 'vfsmount-guts', 'umode_t' and 'partitions' into Z
2012-01-06 23:15:54 -05:00
namespace.c
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
2012-01-08 13:21:22 -08:00
no-block.c
…
open.c
switch security_path_chmod() to struct path *
2012-01-06 23:16:53 -05:00
pipe.c
pipe: fail cleanly when root tries F_SETPIPE_SZ with big size
2012-01-12 20:13:04 -08:00
pnode.c
vfs: switch pnode.h macros to struct mount *
2012-01-03 22:57:11 -05:00
pnode.h
vfs: switch pnode.h macros to struct mount *
2012-01-03 22:57:11 -05:00
posix_acl.c
vfs: pass all mask flags check_acl and posix_acl_permission
2011-10-28 14:58:54 +02:00
proc_namespace.c
vfs: switch ->show_options() to struct dentry *
2012-01-06 23:19:54 -05:00
read_write.c
Cross Memory Attach
2011-10-31 17:30:44 -07:00
read_write.h
…
readdir.c
…
select.c
…
seq_file.c
constify seq_file stuff
2012-01-03 22:52:40 -05:00
signalfd.c
…
splice.c
fs: move code out of buffer.c
2012-01-03 22:54:07 -05:00
stack.c
filesystems: add set_nlink()
2011-11-02 12:53:43 +01:00
stat.c
readlinkat: ensure we return ENOENT for the empty pathname for normal lookups
2011-11-02 12:53:42 +01:00
statfs.c
vfs: new helper - vfs_ustat()
2012-01-03 22:53:07 -05:00
super.c
vfs: prevent remount read-only if pending removes
2012-01-06 23:20:13 -05:00
sync.c
fs: move code out of buffer.c
2012-01-03 22:54:07 -05:00
timerfd.c
…
utimes.c
…
xattr_acl.c
…
xattr.c
vfs: mnt_drop_write_file()
2012-01-03 22:52:40 -05:00