sugar/linux
1
0
Fork 0
Code Activity

drm/xe: Fix a NULL vs IS_ERR() bug in xe_i2c_register_adapter()

Browse Source 
The fwnode_create_software_node() function returns error pointers.  It
never returns NULL.  Update the checks to match.

Fixes: f0e53aadd7 ("drm/xe: Support for I2C attached MCUs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://lore.kernel.org/r/65825d00-81ab-4665-af51-4fff6786a250@sabinyo.mountain
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
(cherry picked from commit 2f264d58cc)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
This commit is contained in:
Dan Carpenter
2025-07-15 17:59:44 -05:00
committed by Rodrigo Vivi
parent 6aaceed7fe
commit 2bd986021c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/xe/xe_i2c.c
View File

@@ -96,8 +96,8 @@ static int xe_i2c_register_adapter(struct xe_i2c *i2c)
int ret;
fwnode = fwnode_create_software_node(xe_i2c_adapter_properties, NULL);
if (!fwnode)
return -ENOMEM;
if (IS_ERR(fwnode))
return PTR_ERR(fwnode);
/*
* Not using platform_device_register_full() here because we don't have