sugar/linux
1
0
Fork 0
Code Activity

ACPICA: acpidump: fix return values in ap_is_valid_checksum()

Browse Source 
The function ap_is_valid_checksum() has a boolean name suggesting it
should return TRUE/FALSE, but incorrectly returns AE_OK on success and
has no explicit return on failure, leading to undefined behavior.

Fix by returning proper values:
 - FALSE when checksum validation fails
 - TRUE when checksum validation succeeds

Link: https://github.com/acpica/acpica/commit/479ba862
Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Kaushlendra Kumar
2025-09-12 22:06:08 +02:00
committed by Rafael J. Wysocki
parent 81f92cff6d
commit 54ba9071a0
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tools/power/acpi/tools/acpidump/apdump.c
View File

@@ -86,9 +86,10 @@ u8 ap_is_valid_checksum(struct acpi_table_header *table)
if (ACPI_FAILURE(status)) {
fprintf(stderr, "%4.4s: Warning: wrong checksum in table\n",
table->signature);
return (FALSE);
}
return (AE_OK);
return (TRUE);
}
/******************************************************************************