sugar/linux
1
0
Fork 0
Code Activity

mei: vsc: Unset the event callback on remove and probe errors

Browse Source 
Make mei_vsc_remove() properly unset the callback to avoid a dead callback
sticking around after probe errors or unbinding of the platform driver.

Fixes: 386a766c41 ("mei: Add MEI hardware support for IVSC device")
Signed-off-by: Hans de Goede <hansg@kernel.org>
Link: https://lore.kernel.org/r/20250623085052.12347-8-hansg@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Hans de Goede
2025-06-23 10:50:49 +02:00
committed by Greg Kroah-Hartman
parent 18f14b2e7f
commit 6175c69740
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/misc/mei/platform-vsc.c
View File

@@ -380,6 +380,8 @@ err_stop:
err_cancel:
mei_cancel_work(mei_dev);
vsc_tp_register_event_cb(tp, NULL, NULL);
mei_disable_interrupts(mei_dev);
return ret;
@@ -388,11 +390,14 @@ err_cancel:
static void mei_vsc_remove(struct platform_device *pdev)
{
struct mei_device *mei_dev = platform_get_drvdata(pdev);
struct mei_vsc_hw *hw = mei_dev_to_vsc_hw(mei_dev);
pm_runtime_disable(mei_dev->dev);
mei_stop(mei_dev);
vsc_tp_register_event_cb(hw->tp, NULL, NULL);
mei_disable_interrupts(mei_dev);
mei_deregister(mei_dev);