sugar/linux
1
0
Fork 0
Code Activity

ext4: Add a WARN_ON_ONCE for querying LAST_IN_LEAF instead

Browse Source 
We added the documentation in ext4_map_blocks() for usage of
EXT4_GET_BLOCKS_QUERY_LAST_IN_LEAF flag. But It's better to add
a WARN_ON_ONCE in case if anyone tries using this flag with CREATE to
avoid a random issue later. Since depth can change with CREATE and it
needs to be re-calculated before using it in there.

Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Link: https://patch.msgid.link/ee6e82a224c50b432df9ce1ce3333c50182d8473.1747677758.git.ritesh.list@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
This commit is contained in:
Ritesh Harjani (IBM)
2025-05-19 23:49:30 +05:30
committed by Theodore Ts'o
parent 618320daa9
commit 7acd1b315c
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
fs/ext4/extents.c
View File

@@ -4445,9 +4445,11 @@ out:
* need to re-calculate the depth as it might have changed due to block
* allocation.
*/
if (flags & EXT4_GET_BLOCKS_QUERY_LAST_IN_LEAF)
if (flags & EXT4_GET_BLOCKS_QUERY_LAST_IN_LEAF) {
WARN_ON_ONCE(flags & EXT4_GET_BLOCKS_CREATE);
if (!err && ex && (ex == EXT_LAST_EXTENT(path[depth].p_hdr)))
map->m_flags |= EXT4_MAP_QUERY_LAST_IN_LEAF;
}
ext4_free_ext_path(path);