sugar/linux
1
0
Fork 0
Code Activity

drm/gem: Correct error condition in drm_gem_objects_lookup

Browse Source 
When vmemdup_array_user() fails, 'handles' is set to a negative error
code and no memory is allocated. So the call to kvfree() should not
happen. Instead just return early with the error code.

Fixes: cb77b79abf ("drm/gem: Use vmemdup_array_user in drm_gem_objects_lookup")
Signed-off-by: Steven Price <steven.price@arm.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Link: https://patch.msgid.link/20251124112039.117748-1-steven.price@arm.com
This commit is contained in:
Steven Price
2025-11-24 11:20:38 +00:00
parent e20c626047
commit 922682d48d
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/gpu/drm/drm_gem.c
View File

@@ -798,13 +798,10 @@ int drm_gem_objects_lookup(struct drm_file *filp, void __user *bo_handles,
*objs_out = objs;
handles = vmemdup_array_user(bo_handles, count, sizeof(u32));
if (IS_ERR(handles)) {
ret = PTR_ERR(handles);
goto out;
}
if (IS_ERR(handles))
return PTR_ERR(handles);
ret = objects_lookup(filp, handles, count, objs);
out:
kvfree(handles);
return ret;