sugar/linux
1
0
Fork 0
Code Activity

pinctrl: sunxi: use kcalloc() instead of kzalloc()

Browse Source 
Use devm_kcalloc() in init_pins_table() and prepare_function_table() to
gain built-in overflow protection, making memory allocation safer when
calculating allocation size compared to explicit multiplication.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Link: https://lore.kernel.org/20250819143935.372084-5-rongqianfeng@vivo.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Qianfeng Rong
2025-08-19 22:39:35 +08:00
committed by Linus Walleij
parent 42311ea583
commit a90d6f4aa0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c
View File

@@ -103,7 +103,7 @@ static struct sunxi_desc_pin *init_pins_table(struct device *dev,
return ERR_PTR(-EINVAL);
}
pins = devm_kzalloc(dev, desc->npins * sizeof(*pins), GFP_KERNEL);
pins = devm_kcalloc(dev, desc->npins, sizeof(*pins), GFP_KERNEL);
if (!pins)
return ERR_PTR(-ENOMEM);
@@ -199,7 +199,7 @@ static int prepare_function_table(struct device *dev, struct device_node *pnode,
* Allocate the memory needed for the functions in one table.
* We later use pointers into this table to mark each pin.
*/
func = devm_kzalloc(dev, num_funcs * sizeof(*func), GFP_KERNEL);
func = devm_kcalloc(dev, num_funcs, sizeof(*func), GFP_KERNEL);
if (!func)
return -ENOMEM;