sugar/linux
1
0
Fork 0
Code Activity

drm/st7571-i2c: Fix IS_ERR() vs NULL checks in probe()

Browse Source 
The devm_kzalloc() function returns NULL on failure, not error pointers.
Also printing an error message for kmalloc() failures is against kernel
style so just return -ENOMEM without printing a message.  (Kmalloc
already prints a message).

Fixes: 4b35f0f41e ("drm/st7571-i2c: add support for Sitronix ST7571 LCD controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://lore.kernel.org/r/aBHZYgPPPYY-J8Vd@stanley.mountain
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
This commit is contained in:
Dan Carpenter
2025-04-30 11:03:46 +03:00
committed by Javier Martinez Canillas
parent 0d607a59a0
commit b389df0f6b
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/gpu/drm/tiny/st7571-i2c.c
View File

@@ -908,16 +908,14 @@ static int st7571_probe(struct i2c_client *client)
st7571->hwbuf = devm_kzalloc(&client->dev,
(st7571->nlines * st7571->ncols * st7571->bpp) / 8,
GFP_KERNEL);
if (IS_ERR(st7571->hwbuf))
return dev_err_probe(&client->dev, PTR_ERR(st7571->hwbuf),
"Failed to allocate intermediate buffer\n");
if (!st7571->hwbuf)
return -ENOMEM;
st7571->row = devm_kzalloc(&client->dev,
(st7571->ncols * st7571->bpp),
GFP_KERNEL);
if (IS_ERR(st7571->row))
return dev_err_probe(&client->dev, PTR_ERR(st7571->row),
"Failed to allocate row buffer\n");
if (!st7571->row)
return -ENOMEM;
ret = st7571_mode_config_init(st7571);
if (ret)