sugar/linux
1
0
Fork 0
Code Activity

mmc: tmio, renesas_sdhi: Remove unneeded NULL check

Browse Source 
The inconsistent NULL checking in this function causes static checker
warnings.

    drivers/mmc/host/renesas_sdhi_sys_dmac.c:360 renesas_sdhi_sys_dmac_issue_tasklet_fn()
    error: we previously assumed 'host' could be null (see line 351)

On reviewing this code, "host" can't ever be NULL so we can just remove
the check.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Dan Carpenter
2018-01-09 12:39:10 +03:00
committed by Ulf Hansson
parent 90e1d8ccdb
commit b8155d3ff3
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/mmc/host/renesas_sdhi_sys_dmac.c
View File

@@ -348,7 +348,7 @@ static void renesas_sdhi_sys_dmac_issue_tasklet_fn(unsigned long priv)
spin_lock_irq(&host->lock);
if (host && host->data) {
if (host->data) {
if (host->data->flags & MMC_DATA_READ)
chan = host->chan_rx;
else