sugar/linux
1
0
Fork 0
Code Activity

mtd: rawnand: lpc32xx_slc: fix GPIO descriptor leak on probe error and remove

Browse Source 
The driver calls gpiod_get_optional() in the probe function but
never calls gpiod_put() in the remove function or in the probe
error path. This leads to a GPIO descriptor resource leak.
The lpc32xx_mlc.c driver in the same directory handles this
correctly by calling gpiod_put() on both paths.

Add gpiod_put() in the remove function and in the probe error path
to fix the resource leak.

Fixes: 6b923db286 ("mtd: rawnand: lpc32xx_slc: switch to using gpiod API")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
This commit is contained in:
Haotian Zhang
2025-10-28 17:47:47 +08:00
committed by Miquel Raynal
parent 2052c1e59b
commit cdf44f1add
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/mtd/nand/raw/lpc32xx_slc.c
View File

@@ -937,6 +937,7 @@ release_dma:
dma_release_channel(host->dma_chan);
enable_wp:
lpc32xx_wp_enable(host);
gpiod_put(host->wp_gpio);
return res;
}
@@ -962,6 +963,7 @@ static void lpc32xx_nand_remove(struct platform_device *pdev)
writel(tmp, SLC_CTRL(host->io_base));
lpc32xx_wp_enable(host);
gpiod_put(host->wp_gpio);
}
static int lpc32xx_nand_resume(struct platform_device *pdev)