sugar/linux
1
0
Fork 0
Code Activity

md/md-bitmap: remove the parameter 'init' for bitmap_ops->resize()

Browse Source 
It's set to 'false' for all callers, hence it's useless and can be
removed.

Link: https://lore.kernel.org/linux-raid/20250707012711.376844-3-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Xiao Ni <xni@redhat.com>
This commit is contained in:
Yu Kuai
2025-07-07 09:26:59 +08:00
parent ba28afbd9e
commit e57b225c28
7 changed files with 11 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/md/dm-raid.c
View File

@@ -4071,7 +4071,7 @@ static int raid_preresume(struct dm_target *ti)
int chunksize = to_bytes(rs->requested_bitmap_chunk_sectors) ?: mddev->bitmap_info.chunksize;
r = mddev->bitmap_ops->resize(mddev, mddev->dev_sectors,
chunksize, false);
chunksize);
if (r)
DMERR("Failed to resize bitmap");
}

5
drivers/md/md-bitmap.c
View File

@@ -2593,15 +2593,14 @@ err:
return ret;
}
static int bitmap_resize(struct mddev *mddev, sector_t blocks, int chunksize,
bool init)
static int bitmap_resize(struct mddev *mddev, sector_t blocks, int chunksize)
{
struct bitmap *bitmap = mddev->bitmap;
if (!bitmap)
return 0;
return __bitmap_resize(bitmap, blocks, chunksize, init);
return __bitmap_resize(bitmap, blocks, chunksize, false);
}
static ssize_t

3
drivers/md/md-bitmap.h
View File

@@ -64,8 +64,7 @@ struct md_bitmap_stats {
struct bitmap_operations {
bool (*enabled)(struct mddev *mddev);
int (*create)(struct mddev *mddev);
int (*resize)(struct mddev *mddev, sector_t blocks, int chunksize,
bool init);
int (*resize)(struct mddev *mddev, sector_t blocks, int chunksize);
int (*load)(struct mddev *mddev);
void (*destroy)(struct mddev *mddev);

2
drivers/md/md-cluster.c
View File

@@ -630,7 +630,7 @@ static int process_recvd_msg(struct mddev *mddev, struct cluster_msg *msg)
if (le64_to_cpu(msg->high) != mddev->pers->size(mddev, 0, 0))
ret = mddev->bitmap_ops->resize(mddev,
le64_to_cpu(msg->high),
0, false);
0);
break;
default:
ret = -1;

2
drivers/md/raid1.c
View File

@@ -3330,7 +3330,7 @@ static int raid1_resize(struct mddev *mddev, sector_t sectors)
mddev->array_sectors > newsize)
return -EINVAL;
ret = mddev->bitmap_ops->resize(mddev, newsize, 0, false);
ret = mddev->bitmap_ops->resize(mddev, newsize, 0);
if (ret)
return ret;

8
drivers/md/raid10.c
View File

@@ -4239,7 +4239,7 @@ static int raid10_resize(struct mddev *mddev, sector_t sectors)
mddev->array_sectors > size)
return -EINVAL;
ret = mddev->bitmap_ops->resize(mddev, size, 0, false);
ret = mddev->bitmap_ops->resize(mddev, size, 0);
if (ret)
return ret;
@@ -4508,7 +4508,7 @@ static int raid10_start_reshape(struct mddev *mddev)
newsize = raid10_size(mddev, 0, conf->geo.raid_disks);
if (!mddev_is_clustered(mddev)) {
ret = mddev->bitmap_ops->resize(mddev, newsize, 0, false);
ret = mddev->bitmap_ops->resize(mddev, newsize, 0);
if (ret)
goto abort;
else
@@ -4530,13 +4530,13 @@ static int raid10_start_reshape(struct mddev *mddev)
MD_FEATURE_RESHAPE_ACTIVE)) || (oldsize == newsize))
goto out;
ret = mddev->bitmap_ops->resize(mddev, newsize, 0, false);
ret = mddev->bitmap_ops->resize(mddev, newsize, 0);
if (ret)
goto abort;
ret = mddev->cluster_ops->resize_bitmaps(mddev, newsize, oldsize);
if (ret) {
mddev->bitmap_ops->resize(mddev, oldsize, 0, false);
mddev->bitmap_ops->resize(mddev, oldsize, 0);
goto abort;
}
}

2
drivers/md/raid5.c
View File

@@ -8322,7 +8322,7 @@ static int raid5_resize(struct mddev *mddev, sector_t sectors)
mddev->array_sectors > newsize)
return -EINVAL;
ret = mddev->bitmap_ops->resize(mddev, sectors, 0, false);
ret = mddev->bitmap_ops->resize(mddev, sectors, 0);
if (ret)
return ret;