sugar/linux
1
0
Fork 0
Code Activity

spi: stm32: fix sram pool free in probe error path

Browse Source 
Add a test to check whether the sram_pool is NULL before freeing it.

Fixes: d17dd2f1d8 ("spi: stm32: use STM32 DMA with STM32 MDMA to enhance DDR use")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Alain Volmat <alain.volmat@foss.st.com>
Signed-off-by: Clément Le Goffic <clement.legoffic@foss.st.com>
Link: https://patch.msgid.link/20250630-spi-fix-v2-1-4680939e2a3e@foss.st.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Clément Le Goffic
2025-06-30 14:59:23 +02:00
committed by Mark Brown
parent 7e1c28fbf2
commit f4d8438e6a
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/spi/spi-stm32.c
View File

@@ -2486,7 +2486,9 @@ err_pm_disable:
if (spi->mdma_rx)
dma_release_channel(spi->mdma_rx);
err_pool_free:
gen_pool_free(spi->sram_pool, (unsigned long)spi->sram_rx_buf, spi->sram_rx_buf_size);
if (spi->sram_pool)
gen_pool_free(spi->sram_pool, (unsigned long)spi->sram_rx_buf,
spi->sram_rx_buf_size);
err_dma_release:
if (spi->dma_tx)
dma_release_channel(spi->dma_tx);